Fixed Capsule collider generating incorrect dimensions - #848
Open
Elevons wants to merge 5 commits into
Open
Conversation
|
|
||
| private _createCapsuleCollisionMesh(sourceMesh: AbstractMesh, boundingInfo: BoundingInfo): void { | ||
| const size = boundingInfo.boundingBox.maximum.subtract(boundingInfo.boundingSphere.minimum); | ||
| const size = boundingInfo.boundingBox.maximum.subtract(boundingInfo.boundingBox.minimum); |
Contributor
There was a problem hiding this comment.
Nice catch! I missed that part!
Replacing boundingBox by boundingSphere on both minumum and maximum did not do the trick?
| {this._getCollisionType(this._collisionMesh, "lod", <GiMeshNetwork size={42} />)} | ||
| </div> | ||
| <> | ||
| <EditorInspectorSwitchField |
Contributor
There was a problem hiding this comment.
Just ot understand, what is the purpose of it?
Contributor
|
@Elevons any news? |
Author
|
Sorry, on what? |
Contributor
I reviewed and asked some questions about the features you are adding in this PR |
Author
|
I think I've answered them all now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capsule Collider was creating the a collider with the wrong dimensions, fixed it! :)