NativeEngine: support standalone sampleable depth/stencil textures

[bkaradzic-microsoft]

What

NativeEngine::CreateFrameBuffer now supports Babylon's request for a standalone, sampleable depth/stencil texture.

thinNativeEngine.pure.ts::_createDepthStencilTexture creates such a texture by calling createFrameBuffer(...) with a freshly-created (and therefore uninitialized) color texture — its bgfx handle is still kInvalidHandle. CreateFrameBuffer only guarded against a null texture, so it attached the invalid handle as a color target. bgfx framebuffer validation then rejected it (Invalid texture attachment) and threw, which aborted the entire headless Playground sweep, not just the offending test.

How

Detect the request (non-null texture whose bgfx handle is invalid) and instead:

• skip attaching the invalid color handle → build a depth-only framebuffer;
• allocate the depth attachment as a readable BGFX_TEXTURE_RT (instead of BGFX_TEXTURE_RT_WRITE_ONLY) so it can be sampled;
• alias the framebuffer's depth attachment back into the caller-supplied texture (ownsHandle = false, since the framebuffer owns/destroys the handle) so Babylon can sample it (e.g. fluid rendering's depth copy).

Verification

• Built Playground (Win32 D3D11, RelWithDebInfo) off master + this change.
• The fluid-rendering test that previously threw Invalid texture attachment and aborted the sweep now runs to completion with a clean exit (no abort, no stderr). RenderDoc confirms the aliased depth/stencil texture holds correct scene depth.

Does this re-enable any excluded tests?

Honest answer: not on its own. I A/B-tested every crash-reason–excluded test (built with and without this change, run in isolation):

• No currently-excluded test except the fluid one exercises this code path, so none are unblocked by this fix.
• The fluid test itself still cannot be re-enabled: with the crash gone it renders black because of a separate, pre-existing NativeEngine GPU-particle limitation — the fluid particle vertex shader never receives per-instance particle positions (they're uploaded to bgfx instance slot TEXCOORD7/i_data0, but the compiled shader reads POSITION0 from the per-vertex buffer), so all particles render zero-area quads and produce no fragments. That's tracked separately and needs a fix in NativeEngine's instanced-attribute routing.

This PR is therefore a robustness/correctness fix: it removes a whole-sweep abort and makes standalone depth/stencil textures behave per Babylon's contract (sampleable), independent of the unrelated particle issue.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

[Copilot]

Pull request overview

This PR updates the NativeEngine framebuffer creation path to correctly handle Babylon’s request for a standalone, sampleable depth/stencil texture by interpreting an incoming non-null Graphics::Texture* with an invalid bgfx handle as a “depth-only framebuffer” request and then aliasing the created depth attachment back onto the provided texture for sampling.

Changes:

• Detect “standalone depth/stencil texture” requests (non-null texture with invalid bgfx handle) and avoid attaching the invalid color target.
• Create the depth attachment as readable (BGFX_TEXTURE_RT) for the standalone depth/stencil texture case, while keeping existing write-only behavior for normal render-target depth attachments.
• Alias the framebuffer’s depth attachment back into the caller-provided Graphics::Texture with ownsHandle = false so Babylon can sample it.

[bkaradzic-microsoft]

Good catch - fixed in e661432. CreateFrameBuffer now reports hasDepth = (generateDepth || generateStencilBuffer) so the stencil-without-depth path (which allocates a combined D24S8 attachment) no longer reports HasDepth()==false and won't skip depth clear / Z-writes.

[bkaradzic-microsoft]

Closing as superseded.

This branch's head (5088a3cc) is a direct ancestor of the shotgun integration branch, where its two functional commits (80efb8c7 standalone sampleable depth/stencil, a9ce9659 report depth present when stencil-without-depth allocates depth/stencil) have since been built on substantially. They will be re-proposed as part of a single coherent framebuffers & render targets PR (BN-1) covering depth/stencil, MRT, cube & 3D render targets, MSAA attachments, numLayers and mip auto-gen control, rather than as an isolated slice.

Nothing is lost: the work is preserved commit-for-commit and is now validated against the full 720-test Playground comparison suite instead of the handful this draft could exercise. The Apps/package.json babylonjs bump is dropped -- test-enablement and dependency pins are being landed separately from engine changes.