"Integrations" (simple) API layer#1701
Draft
ryantrem wants to merge 47 commits into
Draft
Conversation
Add ShaderCache support
Add zero size check
Add options to Playground::Initialize Update win32 playground to pass options from cmd options (parity with master AppContext)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating as draft for now, will flesh out the description more later.
Some open questions and remaining work:
Runtime::RunOnJsThreadcurrently always runs throughScriptLoaderin case what is being run needs JS scripts first. This was AI's idea, but I'm not sure it is right. I could see it being useful, but maybe there should be a parameter for it or something?Runtime::CreateandView::Attachreturnunique_ptr. This was an AI decision, but I'm not sure why. Seems like it could be a regular movable class.