Snippet rewrite: handle single-quoted texture and scenes paths in validation_native.js#1699
Open
bkaradzic-microsoft wants to merge 1 commit into
Open
Conversation
…ion_native.js The eval-time URL rewrite rules in validation_native.js only matched double-quoted texture/scenes paths. Snippets that use single quotes (e.g. `'/textures/albedo.png'`) slipped through and hit raw absolute URLs, producing `Error: Unknown error opening URL` at load time. Added single-quote variants for `/textures/`, `textures/`, and `scenes/` to mirror the existing double-quote rules. No behavior change for any snippet that already worked. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The URL rewrite rules in
Apps/Playground/Scripts/validation_native.jsonly matched double-quoted texture and scenes paths in playground snippet code. Snippets that use single quotes -- e.g.BABYLON.Texture('/textures/albedo.png')-- slipped past the rewrite and hit raw absolute URLs at load time, producingError: Unknown error opening URLand a hung snippet-mode retry loop.This adds single-quote variants for the existing
/textures/,textures/, andscenes/rules so both quote styles get rewritten to the absolutehttps://playground.babylonjs.com/...form, matching the existing behavior for double-quoted paths. No behavior change for any snippet that already worked.Verified locally on Win32 D3D11 Release that the snippet which originally hit this error now loads its texture asset and proceeds to the next stage of evaluation (separate, unrelated failure path -- not addressed here).