[Core] Fix Pylint Errors - Import related issues

sdk/core/azure-core/samples/example_shared_transport.py

@@ -19,6 +19,7 @@
     1) AZURE_STORAGE_CONNECTION_STRING - the endpoint of your Azure Metrics Advisor service
 """
 
+# pylint: disable=non-abstract-transport-import,networking-import-outside-azure-core-transport
 import os
 from azure.core.pipeline.transport import RequestsTransport
 from azure.storage.blob import BlobServiceClient
@@ -33,7 +34,8 @@ def shared_transport():
     session = requests.Session()
     shared_transport = RequestsTransport(
         session=session, session_owner=False
-    )  # here we set session_owner to False to indicate that we don't want to close the session when the client is closed
+    )  # here we set session_owner to False to indicate that we don't want to
+    # close the session when the client is closed
     with shared_transport:
         blob_service_client1 = BlobServiceClient.from_connection_string(
             connection_string,

sdk/core/azure-core/samples/example_shared_transport_async.py

@@ -19,6 +19,7 @@
     1) AZURE_STORAGE_CONNECTION_STRING - the endpoint of your Azure Metrics Advisor service
 """
 
+# pylint: disable=non-abstract-transport-import,networking-import-outside-azure-core-transport
 import os
 import asyncio
 from azure.core.pipeline.transport import AioHttpTransport
@@ -34,7 +35,8 @@ async def shared_transport_async():
     session = aiohttp.ClientSession()
     shared_transport = AioHttpTransport(
         session=session, session_owner=False
-    )  # here we set session_owner to False to indicate that we don't want to close the session when the client is closed
+    )  # here we set session_owner to False to indicate that we don't want to
+    # close the session when the client is closed
     async with shared_transport:
         blob_service_client1 = BlobServiceClient.from_connection_string(
             connection_string,

sdk/core/azure-core/samples/example_truststore_injection.py

@@ -26,6 +26,9 @@
 # Inject truststore BEFORE importing Azure SDK libraries
 truststore.inject_into_ssl()
 
+# Azure SDK imports must follow truststore injection so the OS certificate
+# store is used for TLS; the out-of-order position is intentional here.
+# pylint: disable=wrong-import-position
 # Synchronous imports
 from azure.identity import DefaultAzureCredential
 from azure.storage.blob import BlobServiceClient

sdk/core/azure-core/samples/example_truststore_ssl_context.py

@@ -22,6 +22,7 @@
     python example_truststore_ssl_context.py
 """
 
+# pylint: disable=non-abstract-transport-import,networking-import-outside-azure-core-transport
 import ssl
 import asyncio
 import truststore

sdk/core/azure-core/samples/test_example_async.py

@@ -23,15 +23,17 @@
 # THE SOFTWARE.
 #
 # --------------------------------------------------------------------------
+# pylint: disable=non-abstract-transport-import,networking-import-outside-azure-core-transport
 from typing import Iterable, MutableSequence, Union
+
 import pytest
+import trio
+
 from azure.core.pipeline import AsyncPipeline
 from azure.core import AsyncPipelineClient
 from azure.core.pipeline.policies import AsyncHTTPPolicy, SansIOHTTPPolicy, UserAgentPolicy, AsyncRedirectPolicy
 from azure.core.rest import HttpRequest, AsyncHttpResponse
 
-import trio
-
 
 @pytest.mark.asyncio
 async def test_example_trio():

sdk/core/azure-core/samples/test_example_policies.py

@@ -32,8 +32,7 @@ def callback(response):
 
     from azure.core.pipeline import Pipeline
     from azure.core.rest import HttpRequest
-    from azure.core.pipeline.policies import RedirectPolicy, UserAgentPolicy
-    from azure.core.pipeline.transport import RequestsTransport
+    from azure.core.pipeline.transport import RequestsTransport  # pylint: disable=non-abstract-transport-import
     from azure.core.pipeline.policies import CustomHookPolicy
 
     request = HttpRequest("GET", "https://bing.com")

sdk/core/azure-core/samples/test_example_sansio.py

@@ -24,13 +24,11 @@
 #
 # --------------------------------------------------------------------------
 
-import sys
 from azure.core.pipeline import PipelineRequest
 from azure.core.rest import HttpRequest, HttpResponse
 from azure.core import PipelineClient
 from azure.core.pipeline.policies import RedirectPolicy
 from azure.core.pipeline.policies import UserAgentPolicy
-from azure.core.pipeline.policies import SansIOHTTPPolicy
 from azure.core.pipeline.policies import RequestIdPolicy
 
 
@@ -62,8 +60,6 @@ def test_example_request_id_policy():
     policies = [UserAgentPolicy("myuseragent"), RedirectPolicy()]
 
     # [START request_id_policy]
-    from azure.core.pipeline.policies import HeadersPolicy
-
     request_id_policy = RequestIdPolicy()
     request_id_policy.set_request_id("azconfig-test")
 

sdk/core/azure-core/samples/test_example_sync.py

@@ -23,6 +23,7 @@
 # THE SOFTWARE.
 #
 # --------------------------------------------------------------------------
+# pylint: disable=non-abstract-transport-import
 from typing import Iterable, MutableSequence, Union
 from azure.core.pipeline import Pipeline
 from azure.core import PipelineClient

sdk/core/azure-core/tests/async_tests/test_authentication_async.py

@@ -8,7 +8,12 @@
 import sys
 import time
 from unittest.mock import Mock, patch, AsyncMock, create_autospec
+
 from requests import Response
+import pytest
+import trio
+
+from utils import HTTP_REQUESTS
 
 from azure.core.credentials import AccessToken, AccessTokenInfo
 from azure.core.credentials_async import AsyncTokenCredential, AsyncSupportsTokenInfo
@@ -23,10 +28,6 @@
 )
 from azure.core.pipeline.policies._authentication import MAX_REFRESH_JITTER_SECONDS
 from azure.core.pipeline.transport import AsyncHttpTransport, HttpRequest
-import pytest
-import trio
-
-from utils import HTTP_REQUESTS
 
 
 @pytest.mark.asyncio

sdk/core/azure-core/tests/async_tests/test_base_polling_async.py

@@ -26,27 +26,25 @@
 import base64
 import json
 import re
-from utils import HTTP_REQUESTS
-from azure.core.pipeline._tools import is_rest
 import types
 from unittest import mock
 
 import pytest
-
 from requests import Request, Response
+from utils import HTTP_REQUESTS
+from utils import ASYNCIO_REQUESTS_TRANSPORT_RESPONSES, request_and_responses_product, create_transport_response
+from rest_client_async import AsyncMockRestClient
 
+from azure.core.pipeline._tools import is_rest
 from azure.core.polling import async_poller, AsyncLROPoller
 from azure.core.exceptions import DecodeError, HttpResponseError
 from azure.core import AsyncPipelineClient
 from azure.core.pipeline import PipelineResponse, AsyncPipeline, PipelineContext
 from azure.core.pipeline.transport import AsyncioRequestsTransportResponse, AsyncHttpTransport
-
 from azure.core.polling.base_polling import LROBasePolling
 from azure.core.polling.async_base_polling import (
     AsyncLROBasePolling,
 )
-from utils import ASYNCIO_REQUESTS_TRANSPORT_RESPONSES, request_and_responses_product, create_transport_response
-from rest_client_async import AsyncMockRestClient
 
 
 class SimpleResource:

sdk/core/azure-core/tests/async_tests/test_basic_transport_async.py

@@ -4,13 +4,15 @@
 # license information.
 # -------------------------------------------------------------------------
 
-import pytest
+# pylint: disable=line-too-long,useless-suppression
 import sys
 import asyncio
-from packaging.version import Version
 from unittest import mock
 
+import pytest
+from packaging.version import Version
 import aiohttp
+from utils import HTTP_REQUESTS, request_and_responses_product
 
 from azure.core.pipeline.transport import (
     AsyncHttpResponse as PipelineTransportAsyncHttpResponse,
@@ -31,8 +33,6 @@
     ServiceResponseTimeoutError,
 )
 
-from utils import HTTP_REQUESTS, request_and_responses_product
-
 
 # transport = mock.MagicMock(spec=AsyncHttpTransport)
 # MagicMock support async cxt manager only after 3.8
@@ -970,9 +970,6 @@ async def test_recursive_multipart_receive(http_request, mock_response):
 
 @pytest.mark.skipif(sys.version_info < (3, 10), reason="Loop parameter is deprecated since Python 3.10")
 def test_aiohttp_loop():
-    import asyncio
-    from azure.core.pipeline.transport import AioHttpTransport
-
     loop = asyncio.new_event_loop()
     try:
         with pytest.raises(ValueError):

sdk/core/azure-core/tests/async_tests/test_content_length_checking_async.py

@@ -4,13 +4,13 @@
 # Licensed under the MIT License. See LICENSE.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
-from azure.core.pipeline import AsyncPipeline
+import pytest
+
 from azure.core.pipeline.transport import (
     HttpRequest,
 )
 from azure.core import AsyncPipelineClient
 from azure.core.exceptions import IncompleteReadError
-import pytest
 
 
 @pytest.mark.asyncio

sdk/core/azure-core/tests/async_tests/test_http_logging_policy_async.py

@@ -6,14 +6,16 @@
 
 import logging
 import types
-import pytest
 import sys
 from unittest.mock import Mock
+
+import pytest
+from utils import HTTP_RESPONSES, request_and_responses_product, create_http_response
+
 from azure.core.pipeline import PipelineResponse, PipelineRequest, PipelineContext
 from azure.core.pipeline.policies import (
     HttpLoggingPolicy,
 )
-from utils import HTTP_RESPONSES, request_and_responses_product, create_http_response
 
 
 @pytest.mark.parametrize("http_request,http_response", request_and_responses_product(HTTP_RESPONSES))

sdk/core/azure-core/tests/async_tests/test_paging_async.py

@@ -26,11 +26,11 @@
 
 from typing import AsyncIterator, TypeVar, List
 
+import pytest
+
 from azure.core.async_paging import AsyncItemPaged, AsyncList
 from azure.core.exceptions import HttpResponseError
 
-import pytest
-
 
 T = TypeVar("T")
 

sdk/core/azure-core/tests/async_tests/test_pipeline_async.py

@@ -26,6 +26,11 @@
 import sys
 from unittest.mock import Mock
 
+import aiohttp
+import trio
+import pytest
+from utils import HTTP_REQUESTS
+
 from azure.core.credentials import AccessToken
 from azure.core.pipeline import AsyncPipeline
 from azure.core.pipeline.policies import (
@@ -36,7 +41,6 @@
     AsyncRetryPolicy,
     AsyncRedirectPolicy,
     AsyncHTTPPolicy,
-    AsyncRetryPolicy,
     HttpLoggingPolicy,
     SensitiveHeaderCleanupPolicy,
 )
@@ -55,12 +59,6 @@
 from azure.core import AsyncPipelineClient
 from azure.core.exceptions import AzureError
 
-import aiohttp
-import trio
-
-import pytest
-from utils import HTTP_REQUESTS
-
 
 try:
     from unittest.mock import AsyncMock, PropertyMock

sdk/core/azure-core/tests/async_tests/test_polling_async.py

@@ -24,7 +24,6 @@
 #
 # --------------------------------------------------------------------------
 import asyncio
-import time
 
 try:
     from unittest import mock
@@ -34,7 +33,7 @@
 import pytest
 
 from azure.core import AsyncPipelineClient
-from azure.core.polling import *
+from azure.core.polling import NoPolling, AsyncNoPolling, AsyncPollingMethod, AsyncLROPoller
 from azure.core.exceptions import ServiceResponseError
 
 # from msrest.serialization import Model

sdk/core/azure-core/tests/async_tests/test_request_asyncio.py

@@ -5,10 +5,11 @@
 # -------------------------------------------------------------------------
 import json
 
-from azure.core.pipeline.transport import AsyncioRequestsTransport
+import pytest
 from utils import HTTP_REQUESTS
+
+from azure.core.pipeline.transport import AsyncioRequestsTransport
 from azure.core.pipeline._tools import is_rest
-import pytest
 
 
 @pytest.mark.asyncio

sdk/core/azure-core/tests/async_tests/test_request_trio.py

@@ -5,11 +5,11 @@
 # -------------------------------------------------------------------------
 import json
 
-from azure.core.pipeline.transport import TrioRequestsTransport
+import pytest
 from utils import HTTP_REQUESTS
-from azure.core.pipeline._tools import is_rest
 
-import pytest
+from azure.core.pipeline.transport import TrioRequestsTransport
+from azure.core.pipeline._tools import is_rest
 
 
 @pytest.mark.trio

sdk/core/azure-core/tests/async_tests/test_rest_asyncio_transport.py

@@ -3,15 +3,15 @@
 # Licensed under the MIT License. See LICENSE.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
-from azure.core.pipeline.transport import AsyncioRequestsTransport
-from azure.core.rest import HttpRequest
-from azure.core.rest._requests_asyncio import RestAsyncioRequestsTransportResponse
-from rest_client_async import AsyncMockRestClient
-
 import pytest
 import pytest_asyncio
+from rest_client_async import AsyncMockRestClient
 from utils import readonly_checks
 
+from azure.core.pipeline.transport import AsyncioRequestsTransport
+from azure.core.rest import HttpRequest
+from azure.core.rest._requests_asyncio import RestAsyncioRequestsTransportResponse
+
 
 @pytest_asyncio.fixture
 async def client(port):

sdk/core/azure-core/tests/async_tests/test_rest_context_manager_async.py

@@ -4,10 +4,10 @@
 # Licensed under the MIT License. See LICENSE.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
-from azure.core.exceptions import ResponseNotReadError
 import pytest
+
+from azure.core.exceptions import ResponseNotReadError
 from azure.core.rest import HttpRequest
-from rest_client_async import AsyncMockRestClient
 
 
 @pytest.mark.asyncio

sdk/core/azure-core/tests/async_tests/test_rest_headers_async.py

@@ -4,11 +4,10 @@
 # Licensed under the MIT License. See LICENSE.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
+
 import pytest
-import platform
+
 from azure.core.rest import HttpRequest
-import aiohttp
-from azure.core.rest._aiohttp import RestAioHttpTransportResponse
 
 # flask returns these response headers, which we don't really need for these following tests
 RESPONSE_HEADERS_TO_IGNORE = [

sdk/core/azure-core/tests/async_tests/test_rest_http_request_async.py

@@ -6,11 +6,13 @@
 
 # NOTE: These tests are heavily inspired from the httpx test suite: https://github.com/encode/httpx/tree/master/tests
 # Thank you httpx for your wonderful tests!
-import pytest
-from azure.core.rest import HttpRequest
 import collections.abc
+
+import pytest
 from utils import NamedIo
 
+from azure.core.rest import HttpRequest
+
 
 @pytest.fixture
 def assert_aiterator_body():