Update test templates to check weekly runs based on run start time by raych1 · Pull Request #48391 · Azure/azure-sdk-for-python

raych1 · 2026-07-31T17:47:33Z

Summary

determine weekend scheduled runs from the pipeline start time in UTC timezone (gaps with PT zone is accepted)
mark the analyze-weekly stage explicitly for Python CI tooling

Testing

azure-pipelines · 2026-07-31T17:48:15Z

Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

raych1 · 2026-07-31T17:51:25Z

/azp run python - core - tests

azure-pipelines · 2026-07-31T17:51:36Z

Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

azure-pipelines · 2026-07-31T17:51:41Z

Azure Pipelines: Successfully started running 1 pipeline(s).

raych1 · 2026-07-31T17:51:41Z

/azp run python - template - tests

azure-pipelines · 2026-07-31T17:51:53Z

Azure Pipelines: Successfully started running 1 pipeline(s).

Copilot

Pull request overview

Updates weekly analysis scheduling and Python CI context detection.

Changes:

Adds weekend schedule checks and gates analysis stages.
Adds configurable analysis-stage dependencies and conditions.
Replaces pipeline-name detection with an explicit environment marker.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
`eng/tools/azure-sdk-tools/ci_tools/variables.py`	Detects weekly analysis via an explicit variable.
`eng/pipelines/templates/stages/python-analyze-weekly.yml`	Adds gating parameters and the analysis marker.
`eng/pipelines/templates/stages/python-analyze-weekly-standalone.yml`	Adds scheduled weekend gating.
`eng/pipelines/templates/stages/archetype-sdk-tests.yml`	Adds schedule gating for weekly analysis and modifies cloud selection.

raych1 · 2026-07-31T19:08:50Z

    - ${{ each package in coalesce(parameters.Packages, split(parameters.BuildTargetingString, '|')) }}:
      - ${{ each cloud in parameters.CloudConfig }}:
-        - ${{ if or(contains(parameters.Clouds, cloud.key), and(contains(variables['Build.DefinitionName'], 'tests-weekly'), contains(parameters.SupportedClouds, cloud.key))) }}:
+        - ${{ if contains(parameters.Clouds, cloud.key) }}:


Co-authored-by: raych1 <20296335+raych1@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Suppressed comments (2)

eng/pipelines/templates/stages/archetype-sdk-tests.yml:134

This also removes the existing weekly expansion to SupportedClouds, although the PR describes changing only the analyze-stage gate. For example, sdk/personalizer/tests.yml:8 sets Clouds: Canary and relies on the default SupportedClouds: Public; its weekly pipeline previously ran both clouds but will now never create the Public stage. Preserve the supported-cloud stages with a weekend CheckSchedule gate, or document and update callers if dropping weekly multi-cloud coverage is intentional.

        - ${{ if contains(parameters.Clouds, cloud.key) }}:

eng/pipelines/templates/stages/archetype-sdk-tests.yml:126

This computes the weekend from when the CheckSchedule agent happens to execute, not from the pipeline start as the comment and PR require. A queued or delayed run that crosses midnight at the weekend boundary can therefore incorrectly enable or skip weekly analysis.

                  $now = [System.TimeZoneInfo]::ConvertTimeFromUtc([datetime]::UtcNow, $tz)

Co-authored-by: raych1 <20296335+raych1@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Suppressed comments (2)

eng/pipelines/templates/stages/python-analyze-weekly-standalone.yml:33

Build.QueuedTime is not a predefined Azure Pipelines variable, so it remains the literal $(Build.QueuedTime) here and the datetimeoffset cast fails. That makes CheckSchedule fail and prevents every standalone weekly analysis stage from running. Define the same pipeline.startTime runtime variable used by archetype-sdk-tests.yml and parse that value instead.

                  $runStart = ([datetimeoffset]'$(Build.QueuedTime)').UtcDateTime

eng/pipelines/templates/stages/archetype-sdk-tests.yml:137

This removes the existing weekly expansion to SupportedClouds even though the PR only changes analysis-stage gating, and leaves that parameter unused. For example, sdk/personalizer/tests.yml:8 sets Clouds: Canary while retaining the default SupportedClouds: Public; its weekly pipeline previously tested both clouds but will now test only Canary. Preserve the existing cloud-selection condition independently of the new analyze gate.

        - ${{ if contains(parameters.Clouds, cloud.key) }}:

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Suppressed comments (2)

eng/pipelines/templates/stages/python-analyze-weekly-standalone.yml:33

This standalone path also bases the gate on agent execution time rather than pipeline start time. A queued run that starts this step after the weekend boundary will be classified incorrectly. Pass pipeline.startTime into the step via a runtime expression and convert that timestamp instead of calling UtcNow.

                  $now = [System.TimeZoneInfo]::ConvertTimeFromUtc([datetime]::UtcNow, $tz)

eng/pipelines/templates/stages/archetype-sdk-tests.yml:126

This still classifies the run using the time when the agent executes this step, rather than the pipeline start time described by the PR. If CheckSchedule waits in the agent queue across a weekend boundary, the weekly stage will be incorrectly enabled or skipped. Capture pipeline.startTime with a runtime expression and convert that immutable timestamp to the schedule timezone instead.

                  $now = [System.TimeZoneInfo]::ConvertTimeFromUtc([datetime]::UtcNow, $tz)

danieljurek

LGTM, not blocking but I think this can be refactored into a single stage template.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Suppressed comments (1)

eng/pipelines/templates/stages/archetype-sdk-tests.yml:126

The current diff reintroduces the boundary bug: [datetime]::UtcNow is the agent step's execution time, not the pipeline start time promised by this gate. A scheduled run queued before a weekend boundary can therefore be classified using the wrong day. Derive the timezone conversion from an immutable pipeline start/queue timestamp instead.

                  $now = [System.TimeZoneInfo]::ConvertTimeFromUtc([datetime]::UtcNow, $tz)

raych1 · 2026-07-31T19:13:39Z

/azp run python - formrecognizer - tests

azure-pipelines · 2026-07-31T19:13:55Z

Azure Pipelines: Successfully started running 1 pipeline(s).

raych1 · 2026-07-31T19:15:39Z

/azp run python - agrifood - tests

azure-pipelines · 2026-07-31T19:15:52Z

Azure Pipelines: Successfully started running 1 pipeline(s).

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

benbp · 2026-07-31T20:28:25Z

As discussed offline I think it would be better to use the built-in pipeline.startTime variable for the condition check vs. adding a new pre-req stage. The UTC offset with the agent timezone vs. ado org timezone is not a big issue for a weekend schedule boundary.

For matrices that we include conditionally we can start by keeping those weekly pipelines active as legacy while we explore dynamic solutions.

raych1 · 2026-07-31T20:35:44Z

+              $tz  = [System.TimeZoneInfo]::FindSystemTimeZoneById('${{ parameters.TimeZoneId }}')
+              $local = [System.TimeZoneInfo]::ConvertTimeFromUtc($startUtc, $tz)
+              $weekend = $local.DayOfWeek -in 'Saturday','Sunday'
+              Write-Host "PipelineStartTime raw='$raw' -> UTC='$startUtc' -> $($tz.Id)='$local' -> IsWeekend=$weekend"


Validated by this test run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6646707&view=logs&j=5beca728-1b52-5a38-5df0-ea4c137cb2ff&t=181ca748-c212-5bf3-5ddc-3c4e6d093528

raych1 · 2026-07-31T21:44:27Z

/azp run python - template - tests

azure-pipelines · 2026-07-31T21:44:41Z

Azure Pipelines: Successfully started running 1 pipeline(s).

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

raych1 · 2026-08-01T00:36:06Z

/azp run python - template - tests

azure-pipelines · 2026-08-01T00:36:22Z

Azure Pipelines: Successfully started running 1 pipeline(s).

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Suppressed comments (1)

eng/pipelines/templates/stages/archetype-sdk-tests.yml:178

The PR description says weekly analysis is gated on the CheckSchedule output, but this condition recomputes the decision directly from Build.Reason and pipeline.startTime; no CheckSchedule output is referenced anywhere in these changes. Either restore the documented output-based gate or update the PR description so the stated behavior matches the implementation.

            Condition: and(succeeded(), in(format('{0:ddd}', pipeline.startTime), 'Sat', 'Sun'))

Updated test template to handle weekly runs by start time

15a4f20

raych1 marked this pull request as ready for review July 31, 2026 17:51

raych1 requested a review from danieljurek as a code owner July 31, 2026 17:51

Copilot AI review requested due to automatic review settings July 31, 2026 17:51

raych1 requested review from benbp and mikeharder as code owners July 31, 2026 17:51

raych1 self-assigned this Jul 31, 2026

Copilot started reviewing on behalf of raych1 July 31, 2026 17:52 View session

Copilot AI reviewed Jul 31, 2026

View reviewed changes

Copilot started work on behalf of raych1 July 31, 2026 17:58 View session

Use queued time for weekly analyze gate

d68a653

Co-authored-by: raych1 <20296335+raych1@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 31, 2026 18:01

Copilot finished work on behalf of raych1 July 31, 2026 18:02

Copilot started reviewing on behalf of raych1 July 31, 2026 18:02 View session

Copilot started work on behalf of raych1 July 31, 2026 18:05 View session

Copilot AI reviewed Jul 31, 2026

View reviewed changes

Comment thread eng/pipelines/templates/stages/python-analyze-weekly-standalone.yml Outdated

Use pipeline start time for weekend gating

3a7183c

Co-authored-by: raych1 <20296335+raych1@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 31, 2026 18:09

Copilot finished work on behalf of raych1 July 31, 2026 18:10

Copilot started reviewing on behalf of raych1 July 31, 2026 18:11 View session

Copilot AI reviewed Jul 31, 2026

View reviewed changes

Reverted back to use utcnow

4f37921

Copilot AI review requested due to automatic review settings July 31, 2026 18:22

Copilot started reviewing on behalf of raych1 July 31, 2026 18:23 View session

raych1 changed the title ~~Update weekly test templates to use scheduled start time~~ Update test templates to check weekly runs based on run start time Jul 31, 2026

Copilot AI reviewed Jul 31, 2026

View reviewed changes

Added back the change in_analyze_weekly function

7c241e5

Copilot AI review requested due to automatic review settings July 31, 2026 18:46

Copilot started reviewing on behalf of raych1 July 31, 2026 18:46 View session

danieljurek reviewed Jul 31, 2026

View reviewed changes

Comment thread eng/pipelines/templates/stages/archetype-sdk-tests.yml Outdated

danieljurek approved these changes Jul 31, 2026

View reviewed changes

Copilot AI reviewed Jul 31, 2026

View reviewed changes

Extractred check schedule as shared template and use PipelineStartTime

9aaa774

Copilot AI review requested due to automatic review settings July 31, 2026 20:24

Copilot started reviewing on behalf of raych1 July 31, 2026 20:24 View session

Copilot AI reviewed Jul 31, 2026

View reviewed changes

raych1 commented Jul 31, 2026

View reviewed changes

Removed extra stage and used inline conditions

66a8537

Copilot AI review requested due to automatic review settings August 1, 2026 00:24

Copilot started reviewing on behalf of raych1 August 1, 2026 00:24 View session

Copilot AI reviewed Aug 1, 2026

View reviewed changes

Removed dependson param

a79c769

Copilot AI review requested due to automatic review settings August 1, 2026 00:33

Copilot started reviewing on behalf of raych1 August 1, 2026 00:33 View session

Copilot AI reviewed Aug 1, 2026

View reviewed changes

Uh oh!

Conversation

raych1 commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Uh oh!

azure-pipelines Bot commented Jul 31, 2026

Uh oh!

raych1 commented Jul 31, 2026

Uh oh!

azure-pipelines Bot commented Jul 31, 2026

Uh oh!

azure-pipelines Bot commented Jul 31, 2026

Uh oh!

raych1 commented Jul 31, 2026

Uh oh!

azure-pipelines Bot commented Jul 31, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

raych1 Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

danieljurek left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

raych1 commented Jul 31, 2026

Uh oh!

azure-pipelines Bot commented Jul 31, 2026

Uh oh!

raych1 commented Jul 31, 2026

Uh oh!

azure-pipelines Bot commented Jul 31, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

benbp commented Jul 31, 2026

Uh oh!

raych1 Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

raych1 commented Jul 31, 2026

Uh oh!

azure-pipelines Bot commented Jul 31, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

raych1 commented Aug 1, 2026

Uh oh!

azure-pipelines Bot commented Aug 1, 2026

Uh oh!

Copilot AI left a comment

raych1 commented Jul 31, 2026 •

edited

Loading