Update FoundryStorage read validation expectation - #48386
Draft
Shivakishore14 wants to merge 1 commit into
Draft
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Shivakishore14
force-pushed
the
shiva/fix-foundry-storage-hosting-core-1-3-main
branch
from
July 31, 2026 09:45
1208a3b to
4fa2d3d
Compare
Shivakishore14
changed the title
Reflect microsoft-agents-hosting-core 1.3.0 behavior: target_cls is now a required keyword-only argument on AsyncStorageBase.read, so omitting it raises TypeError before adapter validation runs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c4498c39-31d3-4502-ad7e-e3a0c6ecc97a
Shivakishore14
force-pushed
the
shiva/fix-foundry-storage-hosting-core-1-3-main
branch
from
July 31, 2026 09:55
4fa2d3d to
2267259
Compare
Shivakishore14
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the FoundryStorage validation test for microsoft-agents-hosting-core==1.3.0. AsyncStorageBase.read now requires target_cls as a keyword-only argument, so omitting it raises TypeError at the base API boundary instead of the previous ValueError validation path.
This keeps FoundryStorage using the upstream AsyncStorageBase read/write/delete implementations. Valid runtime callers already pass target_cls.
Validation