Skip to content

Use use-python-version.yml - #48362

Open
chidozieononiwu wants to merge 3 commits into
mainfrom
useDevOpsFeedInAnalyzeWeekly
Open

Use use-python-version.yml#48362
chidozieononiwu wants to merge 3 commits into
mainfrom
useDevOpsFeedInAnalyzeWeekly

Conversation

@chidozieononiwu

@chidozieononiwu chidozieononiwu commented Jul 30, 2026

Copy link
Copy Markdown
Member

This pull request updates the way Python versions are set in the python-analyze-weekly.yml pipeline by switching from using the UsePythonVersion@0 task to a shared template. This change improves consistency and maintainability in the pipeline configuration.

Pipeline configuration improvements:

  • Replaced the UsePythonVersion@0 task for Python 3.10 with the /eng/pipelines/templates/steps/use-python-version.yml template, passing versionSpec: '3.10' as a parameter.
  • Replaced the UsePythonVersion@0 task for Python 3.13 (used for docs generation) with the shared template, passing versionSpec: '3.13' as a parameter.

python - agrifood - tests-weekly

Copilot AI review requested due to automatic review settings July 30, 2026 01:16
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the weekly Python analysis pipeline to use the shared Python-version setup template.

Changes:

  • Uses the shared template for Python 3.10 analysis.
  • Uses the shared template for Python 3.13 documentation generation.

Copilot AI review requested due to automatic review settings July 30, 2026 02:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

eng/tools/azure-sdk-tools/tests/test_variables.py:18

  • This call likewise leaves all defaults added by set_envvar_defaults() in the shared test-process environment; monkeypatch will restore only PIP_EXTRA_INDEX_URL. That makes subsequent tests inherit settings such as IN_UV=1 and the pinned virtualenv variables. Snapshot and restore the full environment around the call.
    set_envvar_defaults()

eng/tools/azure-sdk-tools/tests/test_variables.py:11

  • set_envvar_defaults() also writes the four entries in DEFAULT_ENVIRONMENT_VARIABLES directly to the process environment. Because this fixture only tracks PIP_EXTRA_INDEX_URL, those writes survive monkeypatch teardown and can change later tests depending on execution order. Restore the full environment after this assertion (or register every default key with monkeypatch).

This issue also appears on line 18 of the same file.

    set_envvar_defaults()

Copilot AI review requested due to automatic review settings July 30, 2026 18:41
@chidozieononiwu
chidozieononiwu force-pushed the useDevOpsFeedInAnalyzeWeekly branch from a26cbb7 to 716ba43 Compare July 30, 2026 18:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

eng/pipelines/templates/stages/python-analyze-weekly.yml:40

  • The PR description says this change only replaces UsePythonVersion@0, but this block also switches authentication templates, changes repository/feed selection behavior, and disables all additional pip/uv indexes; variables.py additionally removes the global PyPI extra-index default. These dependency-resolution and security-relevant changes need to be described and justified in the PR (or split into a separate PR) so reviewers can assess the actual scope.
          - template: /eng/common/pipelines/templates/steps/python-auth-dev-feed.yml
            parameters:
              DevFeedName: ${{ parameters.DevFeedName }}
              EnableTwineAuth: false
              DisableAdditionalIndexes : true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants