Use use-python-version.yml - #48362
Open
chidozieononiwu wants to merge 3 commits into
Open
Conversation
chidozieononiwu
requested review from
benbp,
danieljurek and
mikeharder
as code owners
July 30, 2026 01:16
|
Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
eng/tools/azure-sdk-tools/tests/test_variables.py:18
- This call likewise leaves all defaults added by
set_envvar_defaults()in the shared test-process environment;monkeypatchwill restore onlyPIP_EXTRA_INDEX_URL. That makes subsequent tests inherit settings such asIN_UV=1and the pinned virtualenv variables. Snapshot and restore the full environment around the call.
set_envvar_defaults()
eng/tools/azure-sdk-tools/tests/test_variables.py:11
set_envvar_defaults()also writes the four entries inDEFAULT_ENVIRONMENT_VARIABLESdirectly to the process environment. Because this fixture only tracksPIP_EXTRA_INDEX_URL, those writes survivemonkeypatchteardown and can change later tests depending on execution order. Restore the full environment after this assertion (or register every default key withmonkeypatch).
This issue also appears on line 18 of the same file.
set_envvar_defaults()
chidozieononiwu
force-pushed
the
useDevOpsFeedInAnalyzeWeekly
branch
from
July 30, 2026 18:41
a26cbb7 to
716ba43
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
eng/pipelines/templates/stages/python-analyze-weekly.yml:40
- The PR description says this change only replaces
UsePythonVersion@0, but this block also switches authentication templates, changes repository/feed selection behavior, and disables all additional pip/uv indexes;variables.pyadditionally removes the global PyPI extra-index default. These dependency-resolution and security-relevant changes need to be described and justified in the PR (or split into a separate PR) so reviewers can assess the actual scope.
- template: /eng/common/pipelines/templates/steps/python-auth-dev-feed.yml
parameters:
DevFeedName: ${{ parameters.DevFeedName }}
EnableTwineAuth: false
DisableAdditionalIndexes : true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the way Python versions are set in the
python-analyze-weekly.ymlpipeline by switching from using theUsePythonVersion@0task to a shared template. This change improves consistency and maintainability in the pipeline configuration.Pipeline configuration improvements:
UsePythonVersion@0task for Python 3.10 with the/eng/pipelines/templates/steps/use-python-version.ymltemplate, passingversionSpec: '3.10'as a parameter.UsePythonVersion@0task for Python 3.13 (used for docs generation) with the shared template, passingversionSpec: '3.13'as a parameter.python - agrifood - tests-weekly