[AutoPR azure-mgmt-edgezones]-generated-from-SDK Generation - Python-6639987 - #48348
[AutoPR azure-mgmt-edgezones]-generated-from-SDK Generation - Python-6639987#48348azure-sdk-automation[bot] wants to merge 3 commits into
Conversation
…ig.yaml', SDK Release Type: stable, and CommitSHA: 'b11c849d192da49ae3d359f8b16d422f65850666' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6635035 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
|
Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Updates the azure-mgmt-edgezones Python package to a newer API/spec generation, modernizes packaging to pyproject.toml, and refreshes generated client/model/runtime code (including cloud-aware ARM endpoint selection).
Changes:
- Bump API version to
2026-10-01, update generated operations/models, and refresh samples. - Migrate packaging metadata from
setup.py/sdk_packaging.tomltopyproject.tomland mark package as stable (1.0.0). - Introduce cloud endpoint selection (
cloud_setting+ ARM endpoints resolution) in sync/async clients and configuration.
Reviewed changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/edgezones/azure-mgmt-edgezones/tsp-location.yaml | Updates the source spec commit reference for generation. |
| sdk/edgezones/azure-mgmt-edgezones/setup.py | Removes legacy setuptools setup script in favor of pyproject-based builds. |
| sdk/edgezones/azure-mgmt-edgezones/sdk_packaging.toml | Removes standalone packaging config (moved into pyproject.toml). |
| sdk/edgezones/azure-mgmt-edgezones/pyproject.toml | Adds PEP 517/621 packaging config, dependencies, and packaging metadata. |
| sdk/edgezones/azure-mgmt-edgezones/generated_samples/operations_list.py | Updates sample metadata to new API version. |
| sdk/edgezones/azure-mgmt-edgezones/generated_samples/extended_zones_unregister.py | Updates sample metadata to new API version. |
| sdk/edgezones/azure-mgmt-edgezones/generated_samples/extended_zones_register.py | Updates sample metadata to new API version. |
| sdk/edgezones/azure-mgmt-edgezones/generated_samples/extended_zones_list_by_subscription.py | Updates sample metadata to new API version. |
| sdk/edgezones/azure-mgmt-edgezones/generated_samples/extended_zones_get.py | Updates sample metadata to new API version. |
| sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/operations/_patch.py | Updates patch scaffold and typing style. |
| sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/operations/_operations.py | Updates operation implementations, paging types, API version, and streaming/decompress behavior. |
| sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/models/_patch.py | Updates patch scaffold and typing style. |
| sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/models/_models.py | Switches models to new base (_utils.model_base.Model) and updates typing. |
| sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/models/_enums.py | Fixes enum docstrings punctuation. |
| sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/aio/operations/_patch.py | Updates async patch scaffold and typing style. |
| sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/aio/operations/_operations.py | Updates async operation implementations, paging types, and streaming/decompress behavior. |
| sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/aio/_patch.py | Updates async patch scaffold and typing style. |
| sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/aio/_configuration.py | Adds cloud_setting and updates API version defaults/docs for async config. |
| sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/aio/_client.py | Adds cloud-aware ARM endpoint resolution and dynamic Self import for async client. |
| sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/_version.py | Promotes version from beta to stable 1.0.0. |
| sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/_utils/init.py | Adds generated _utils package marker. |
| sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/_serialization.py | Modernizes serialization/deserialization utilities and adds duration/fast-path logic. |
| sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/_patch.py | Updates patch scaffold and typing style. |
| sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/_model_base.py | Major refactor/expansion of model base, XML handling, defaults, and (de)serialization behavior. |
| sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/_configuration.py | Adds cloud_setting and updates API version defaults/docs for sync config. |
| sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/_client.py | Adds cloud-aware ARM endpoint resolution and dynamic Self import for sync client. |
| sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/init.py | Adds typing ignore for namespace package path extension. |
| sdk/edgezones/azure-mgmt-edgezones/azure/init.py | Adds typing ignore for namespace package path extension. |
| sdk/edgezones/azure-mgmt-edgezones/apiview-properties.json | Updates APIView mapping keys and adds cross-language version marker. |
| sdk/edgezones/azure-mgmt-edgezones/api.metadata.yml | Adds API metadata output from tooling. |
| sdk/edgezones/azure-mgmt-edgezones/api.md | Adds generated API surface documentation. |
| sdk/edgezones/azure-mgmt-edgezones/_metadata.json | Adds new generation metadata including API versions and emitter details. |
| sdk/edgezones/azure-mgmt-edgezones/_meta.json | Removes legacy generation metadata file. |
| sdk/edgezones/azure-mgmt-edgezones/README.md | Updates Python support and authentication terminology/link. |
| sdk/edgezones/azure-mgmt-edgezones/MANIFEST.in | Updates included files list and recursive include patterns. |
| sdk/edgezones/azure-mgmt-edgezones/CHANGELOG.md | Adds 1.0.0 entry documenting cloud_setting parameter. |
Comments suppressed due to low confidence (1)
sdk/edgezones/azure-mgmt-edgezones/generated_samples/operations_list.py:1
- The
x-ms-original-fileannotation references2026-10-01, which is in the future relative to the current release date in this PR. If the service API version is expected to be available only later, consider validating that the SDK should ship against it now (or update the annotation/API version to the latest currently published spec).
|
Hi, the new api version |
There was a problem hiding this comment.
Hi @mert-s, we have approved the PR. You can move on to merge and release though the action suggestion in Release Plan.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 38 out of 38 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
sdk/edgezones/azure-mgmt-edgezones/CHANGELOG.md:7
- The 1.0.0 notes omit the new
requires-python = ">=3.10"constraint. The previous package supported Python 3.8+, so users on 3.8/3.9 need this compatibility change called out in the release history.
- Client `EdgeZonesMgmtClient` added parameter `cloud_setting` in method `__init__`
…dgeZones/EdgeZones/tspconfig.yaml', API Version: 2026-10-01, SDK Release Type: stable, and CommitSHA: 'e3d848eb1635fe15a89663daa425dd1619df1f37' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6639987 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 38 out of 38 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (3)
sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/_configuration.py:38
- The docstring says the default
api_versionisNoneand thatNoneis a known value, but the implementation defaults to the string "2026-10-01" and stores it asstr. Please align docs and implementation (either document the actual default string and removeNone, or update typing/logic to acceptOptional[str]and handleNoneconsistently across request builders andself._config.api_version).
:keyword api_version: The API version to use for this operation. Known values are "2026-10-01"
and None. Default value is None. If not set, the operation's default API version will be used.
Note that overriding this default value may result in unsupported behavior.
sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/_configuration.py:50
- The docstring says the default
api_versionisNoneand thatNoneis a known value, but the implementation defaults to the string "2026-10-01" and stores it asstr. Please align docs and implementation (either document the actual default string and removeNone, or update typing/logic to acceptOptional[str]and handleNoneconsistently across request builders andself._config.api_version).
api_version: str = kwargs.pop("api_version", "2026-10-01")
sdk/edgezones/azure-mgmt-edgezones/MANIFEST.in:7
- This PR replaces
_meta.jsonwith_metadata.json, butMANIFEST.inno longer includes either file. If downstream tooling or release validation expects the metadata file in sdists, it won’t be present. Consider adding an explicitinclude _metadata.jsonentry (and any other required metadata files) to keep packaging behavior consistent.
include *.md
include LICENSE
include azure/mgmt/edgezones/py.typed
recursive-include tests *.py
recursive-include samples *.py *.md
include azure/__init__.py
include azure/mgmt/__init__.py
Configurations: 'specification/edgezones/resource-manager/Microsoft.EdgeZones/EdgeZones/tspconfig.yaml', API Version: 2026-10-01, SDK Release Type: stable, and CommitSHA: 'e3d848eb1635fe15a89663daa425dd1619df1f37' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6639987 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=35683 Submitted by: mertsahan@microsoft.com