Skip to content

Fix Content-MD5 in FIPS environments #48241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JensWehner wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −1
Open

Fix Content-MD5 in FIPS environments #48241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/storage/azure-storage-blob/azure/storage/blob/_shared/validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def is_crc64_validation(


def calculate_content_md5(data: Union[bytes, IO[bytes]]) -> bytes:
md5 = hashlib.md5() # nosec
md5 = hashlib.md5(usedforsecurity=False) # nosec
if isinstance(data, bytes):
md5.update(data)
elif hasattr(data, "read"):
Expand Down
14 changes: 14 additions & 0 deletions sdk/storage/azure-storage-blob/tests/test_content_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,20 @@

from azure.core.exceptions import ResourceExistsError
from azure.storage.blob import BlobBlock, BlobClient, BlobServiceClient, BlobType, ContainerClient
from azure.storage.blob._shared import validation


def test_content_md5_is_not_used_for_security(monkeypatch):
original_md5 = validation.hashlib.md5

def fips_md5(*args, **kwargs):
if kwargs.get("usedforsecurity") is not False:
raise ValueError("MD5 is unavailable for security use")
return original_md5(*args, **kwargs)

monkeypatch.setattr(validation.hashlib, "md5", fips_md5)

assert validation.calculate_content_md5(b"test") == bytes.fromhex("098f6bcd4621d373cade4e832627b4f6")


def assert_content_md5(request):
Expand Down
Loading