[AutoPR azure-mgmt-storagemover]-generated-from-SDK Generation - Python-6608675#48233
[AutoPR azure-mgmt-storagemover]-generated-from-SDK Generation - Python-6608675#48233azure-sdk-automation[bot] wants to merge 4 commits into
Conversation
…t.StorageMover/StorageMover/tspconfig.yaml', SDK Release Type: stable, and CommitSHA: 'f89d3d95044e14c679785fa9e0d28c7c97af870a' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6608675 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
|
Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Updates the azure-mgmt-storagemover SDK to a newer REST API spec + API version, regenerating clients/models/samples and adjusting tests and package metadata accordingly.
Changes:
- Bump StorageMover management API version/spec commit (to
2026-05-01) and regenerate SDK surface (models, operations, samples). - Add support for new model fields/enums (cross-tenant transfer settings, new schedule frequency/repeat interval, new job type, etc.) and new
reconcile_joboperation. - Update Python support metadata (drop 3.9, require 3.10+) and apply formatting/lint adjustments across tests.
Reviewed changes
Copilot reviewed 105 out of 106 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/storagemover/azure-mgmt-storagemover/tsp-location.yaml | Points generation config to updated specs path + commit. |
| sdk/storagemover/azure-mgmt-storagemover/tests/test_storage_mover_mgmt_storage_movers_operations_test.py | Test formatting + pylint disables. |
| sdk/storagemover/azure-mgmt-storagemover/tests/test_storage_mover_mgmt_storage_movers_operations_async_test.py | Async test formatting + pylint disables. |
| sdk/storagemover/azure-mgmt-storagemover/tests/test_storage_mover_mgmt_projects_operations_test.py | Test formatting + pylint disables. |
| sdk/storagemover/azure-mgmt-storagemover/tests/test_storage_mover_mgmt_projects_operations_async_test.py | Async test formatting + pylint disables. |
| sdk/storagemover/azure-mgmt-storagemover/tests/test_storage_mover_mgmt_job_definitions_operations_async_test.py | Async test formatting + sanitizer/id concatenation refactors. |
| sdk/storagemover/azure-mgmt-storagemover/tests/test_storage_mover_mgmt_endpoints_operations_test.py | Test formatting + pylint disables. |
| sdk/storagemover/azure-mgmt-storagemover/tests/test_storage_mover_mgmt_endpoints_operations_async_test.py | Async test formatting + pylint disables. |
| sdk/storagemover/azure-mgmt-storagemover/tests/test_storage_mover_mgmt_connections_operations_test.py | Test formatting for connection operations. |
| sdk/storagemover/azure-mgmt-storagemover/tests/test_storage_mover_mgmt_connections_operations_async_test.py | Async test formatting for connection operations. |
| sdk/storagemover/azure-mgmt-storagemover/tests/test_storage_mover_mgmt_agents_operations_async_test.py | Removes stray leading diff artifact line. |
| sdk/storagemover/azure-mgmt-storagemover/tests/conftest.py | Sanitizer subscription-id formatting change. |
| sdk/storagemover/azure-mgmt-storagemover/pyproject.toml | Drop Python 3.9; require Python >= 3.10; update classifiers. |
| sdk/storagemover/azure-mgmt-storagemover/generated_tests/test_storage_mover_mgmt_job_definitions_operations_async.py | Update generated payload shapes + add reconcile_job test stub. |
| sdk/storagemover/azure-mgmt-storagemover/generated_tests/test_storage_mover_mgmt_job_definitions_operations.py | Update generated payload shapes + add reconcile_job test stub. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/storage_movers_update.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/storage_movers_list_by_subscription.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/storage_movers_list.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/storage_movers_get.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/storage_movers_delete.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/storage_movers_create_or_update.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/projects_update.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/projects_list.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/projects_get.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/projects_delete.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/projects_create_or_update.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/operations_list.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/job_runs_list.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/job_runs_get_with_schedule.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/job_runs_get.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/job_definitions_update.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/job_definitions_stop_job.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/job_definitions_start_job.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/job_definitions_reconcile_job.py | New sample for reconcile_job operation. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/job_definitions_list.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/job_definitions_get_with_schedule.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/job_definitions_get_cross_tenant_mirror.py | New cross-tenant get sample. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/job_definitions_get_cross_tenant.py | New cross-tenant get sample. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/job_definitions_get.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/job_definitions_delete.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/job_definitions_create_or_update_with_schedule.py | Update API version references + sample start date. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/job_definitions_create_or_update_cross_tenant.py | New cross-tenant create_or_update sample. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/job_definitions_create_or_update_cloud_to_cloud.py | Add new job properties + update API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/job_definitions_create_or_update.py | Add new job properties + update API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_update_smb_mount.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_update_s3_with_hmac.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_update_nfs_mount.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_update_azure_storage_smb_file_share_cross_tenant.py | New cross-tenant endpoint-update sample. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_update_azure_storage_smb_file_share.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_update_azure_storage_nfs_file_share.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_update_azure_storage_blob_container_cross_tenant.py | New cross-tenant endpoint-update sample. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_update_azure_storage_blob_container.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_update_azure_multi_cloud_connector.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_list.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_get_smb_mount.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_get_s3_with_hmac.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_get_nfs_mount.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_get_azure_storage_smb_file_share_cross_tenant.py | New cross-tenant endpoint-get sample. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_get_azure_storage_smb_file_share.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_get_azure_storage_nfs_file_share.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_get_azure_storage_blob_container_cross_tenant.py | New cross-tenant endpoint-get sample. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_get_azure_storage_blob_container.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_get_azure_multi_cloud_connector.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_delete.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_create_or_update_smb_mount.py | Add new endpoint property + update API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_create_or_update_s3_with_hmac.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_create_or_update_nfs_mount.py | Add new endpoint property + update API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_create_or_update_azure_storage_smb_file_share_cross_tenant.py | New cross-tenant endpoint-create sample. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_create_or_update_azure_storage_smb_file_share.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_create_or_update_azure_storage_nfs_file_share.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_create_or_update_azure_storage_blob_container_cross_tenant.py | New cross-tenant endpoint-create sample. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_create_or_update_azure_storage_blob_container.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/endpoints_create_or_update_azure_multi_cloud_connector.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/connections_list.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/connections_get.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/connections_delete.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/connections_create_or_update.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/agents_update.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/agents_list_minimum_set.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/agents_list_maximum_set.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/agents_get_minimum_set.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/agents_get_maximum_set.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/agents_delete.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/agents_create_or_update_upload_limit_schedule_overnight.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/agents_create_or_update_minimum_set.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/generated_samples/agents_create_or_update_maximum_set.py | Update sample original-file API version reference. |
| sdk/storagemover/azure-mgmt-storagemover/azure/mgmt/storagemover/models/_models.py | Add new model fields (cross-tenant, sync mode, schedule repeat interval, endpoint source type, etc.). |
| sdk/storagemover/azure-mgmt-storagemover/azure/mgmt/storagemover/models/_enums.py | Add new enum members (Hourly, new job type, new source-type enums, NFS v4.1). |
| sdk/storagemover/azure-mgmt-storagemover/azure/mgmt/storagemover/models/init.py | Export new enums. |
| sdk/storagemover/azure-mgmt-storagemover/azure/mgmt/storagemover/aio/operations/_operations.py | Add reconcile_job + move request-body typing toward types module. |
| sdk/storagemover/azure-mgmt-storagemover/azure/mgmt/storagemover/aio/_configuration.py | Default API version bump + doc updates. |
| sdk/storagemover/azure-mgmt-storagemover/azure/mgmt/storagemover/aio/_client.py | Self import compatibility + doc updates. |
| sdk/storagemover/azure-mgmt-storagemover/azure/mgmt/storagemover/_version.py | Bump package version to 3.2.0. |
| sdk/storagemover/azure-mgmt-storagemover/azure/mgmt/storagemover/_utils/serialization.py | Add duration numeric formats + header deserialization fast-path + Self import compatibility. |
| sdk/storagemover/azure-mgmt-storagemover/azure/mgmt/storagemover/_configuration.py | Default API version bump + doc updates. |
| sdk/storagemover/azure-mgmt-storagemover/azure/mgmt/storagemover/_client.py | Self import compatibility + doc updates. |
| sdk/storagemover/azure-mgmt-storagemover/apiview-properties.json | Add APIView mappings for new APIs/types. |
| sdk/storagemover/azure-mgmt-storagemover/api.metadata.yml | Add generator metadata stamp. |
| sdk/storagemover/azure-mgmt-storagemover/_metadata.json | Update apiVersion/spec commit + generation metadata. |
| sdk/storagemover/azure-mgmt-storagemover/README.md | Update supported Python version text + terminology change (Entra). |
| sdk/storagemover/azure-mgmt-storagemover/CHANGELOG.md | Add 3.2.0 entry for new features. |
Comments suppressed due to low confidence (3)
sdk/storagemover/azure-mgmt-storagemover/generated_tests/test_storage_mover_mgmt_job_definitions_operations_async.py:1
moverSyncedUntilis modeled/serialized as an RFC3339 datetime (seeformat=\"rfc3339\"in the generated model). The value\"2020-02-20 00:00:00\"is not RFC3339 (missingTand timezone), and is likely to fail serialization. Use an RFC3339 value like\"2020-02-20T00:00:00Z\"(or a proper datetime object if the test uses models instead of raw dicts).
sdk/storagemover/azure-mgmt-storagemover/generated_tests/test_storage_mover_mgmt_job_definitions_operations.py:1- Same as the async generated test:
moverSyncedUntilis expected to be RFC3339. The current string\"2020-02-20 00:00:00\"is not RFC3339 and is likely to break request serialization. Update to an RFC3339 string such as\"2020-02-20T00:00:00Z\".
sdk/storagemover/azure-mgmt-storagemover/generated_tests/test_storage_mover_mgmt_job_definitions_operations_async.py:1 - The new
reconcile_jobgenerated test has no setup (no storage mover/project/job definition created) and no assertions, so it’s likely to fail live (404) and provides no validation even if it succeeds in playback. Consider provisioning the required resources within the test (or reusing ones created earlier in the suite) and assert on the returnedJobRunResourceId(e.g., presence/shape ofjob_run_resource_id), or explicitly mark this as a scaffold/skip so it doesn’t run in CI.
This comment has been minimized.
This comment has been minimized.
|
Hi, the new api version |
|
Hi, we have approved the PR and we will hold the PR merge and release until you explicitly ping us to merge then release. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 105 out of 106 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
sdk/storagemover/azure-mgmt-storagemover/CHANGELOG.md:30
- The release also raises
requires-pythonfrom 3.9 to 3.10, but the new changelog entry lists only API features. This silently omits a compatibility-breaking change from the release notes; add it under a Breaking Changes section so Python 3.9 users can identify why they cannot install 3.2.0.
- Operation group `JobDefinitionsOperations` added method `reconcile_job`
[Pilot] PR Pipeline Failure AnalysisA CI pipeline failed on this pull request. Here is an automated analysis of what went wrong and how to get the build green. What failedThe The pipeline analysis does not include detailed error messages or stack traces, so the exact assertion failure or exception is not visible here. Given that this is an auto-generated SDK PR from TypeSpec (pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6608675), the most likely causes are:
Recommended next steps
Raw pipeline analysis (azsdk ci analyze)
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 108 out of 109 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (3)
sdk/storagemover/azure-mgmt-storagemover/azure/mgmt/storagemover/_client.py:73
- The documented default is inconsistent with the generated configuration: omitting
api_versionstores"2026-05-01", notNone. This public client docstring therefore misleads callers about the effective value. Update the generation source so both client/configuration docstrings report the actual default, then regenerate the sync and async clients.
:keyword api_version: The API version to use for this operation. Known values are "2026-05-01"
and None. Default value is None. If not set, the operation's default API version will be used.
Note that overriding this default value may result in unsupported behavior.
sdk/storagemover/azure-mgmt-storagemover/azure/mgmt/storagemover/aio/_client.py:73
- The documented default is inconsistent with the generated configuration: omitting
api_versionstores"2026-05-01", notNone. This public async-client docstring therefore misleads callers about the effective value. Update the generation source so both client/configuration docstrings report the actual default, then regenerate the sync and async clients.
:keyword api_version: The API version to use for this operation. Known values are "2026-05-01"
and None. Default value is None. If not set, the operation's default API version will be used.
Note that overriding this default value may result in unsupported behavior.
sdk/storagemover/azure-mgmt-storagemover/tests/test_storage_mover_mgmt_storage_movers_operations_test.py:27
- This class-level marker, together with the same marker added to every other custom test class in this package, makes the entire recorded test suite skip in the default playback CI (
sdk/conftest.py:41-47). Sincetests/has no committed recordings, Tests-CI can now pass without exercising any of these management operations. Record the deterministic scenarios and reservelive_test_onlyfor individual tests that genuinely cannot replay instead of disabling every class.
Configurations: 'specification/storagemover/resource-manager/Microsoft.StorageMover/StorageMover/tspconfig.yaml', SDK Release Type: stable, and CommitSHA: 'f89d3d95044e14c679785fa9e0d28c7c97af870a' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6608675 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=35443 Submitted by: