Remove sample_agent_toolbox_skill.py per bakcned folks and Linda requ…#48228
Remove sample_agent_toolbox_skill.py per bakcned folks and Linda requ…#48228howieleung wants to merge 1 commit into
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Adds hosted-agent samples for Teams triggers and reminder previews, while removing the obsolete prompt-agent toolbox sample.
Changes:
- Adds Teams-triggered routine and reminder-preview samples.
- Adds RBAC setup for hosted-agent identities.
- Updates toolbox-agent dependencies and behavior.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
tests/samples/test_samples.py |
Updates hosted-agent sample exclusions. |
sample_toolbox_with_skill.py |
Adds identity RBAC setup. |
sample_toolbox_with_reminder_preview.py |
Adds reminder-preview sample. |
sample_routines_with_teams_message_trigger.py |
Adds Teams-triggered routine sample. |
rbac_util.py |
Adds hosted-agent role assignment utilities. |
assets/toolbox-agent/requirements.txt |
Updates Agent Framework versions. |
assets/toolbox-agent/main.py |
Enables preview tools and skill loading. |
sample_agent_toolbox_skill.py |
Removes obsolete prompt-agent sample. |
Comments suppressed due to low confidence (2)
sdk/ai/azure-ai-projects/samples/hosted_agents/sample_routines_with_teams_message_trigger.py:93
- The usage text says
TEAMS_CONNECTION_NAMEdefaults toteams-conn, but this direct lookup raisesKeyErrorwhen it is omitted. Apply the documented default (or change the documentation to mark it required).
teams_connection_name = os.environ["TEAMS_CONNECTION_NAME"]
sdk/ai/azure-ai-projects/samples/hosted_agents/sample_routines_with_teams_message_trigger.py:98
FOUNDRY_HOSTED_AGENT_REMOTE_BUILDis parsed immediately above, but this hard-codedTrueignores the result, so setting the variable tofalsestill selects REMOTE_BUILD. Pass the parsed value as the other hosted-agent samples do.
dependency_resolution, code_zip_stream = select_basic_agent_code_zip(True)
| "sample_routines_with_schedule_trigger.py", # 500 | ||
| "sample_routines_with_timer_trigger.py", # Timer is used causing request response not matched | ||
| "sample_routines_with_github_issue_trigger.py", # Cannot run without interact on Github | ||
| "sample_routines_with_teams_channel_message_trigger.py", # Cannot run without live Teams event |
[Pilot] PR Pipeline Failure AnalysisA CI pipeline failed on this pull request. Here is an automated analysis of what went wrong and how to get the build green. What failedThree
The PR title indicates Recommended next steps
Raw pipeline analysis (azsdk ci analyze)
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
sdk/ai/azure-ai-projects/samples/hosted_agents/sample_routines_with_teams_message_trigger.py:96
FOUNDRY_HOSTED_AGENT_REMOTE_BUILDis parsed on the preceding line, but hard-codingTruehere means setting it tofalsehas no effect and the bundled path is never selected.
dependency_resolution, code_zip_stream = select_basic_agent_code_zip(True)
|
|
||
| Before running the sample: | ||
|
|
||
| pip install "azure-ai-projects>=2.2.0" python-dotenv |
| endpoint = os.environ["FOUNDRY_PROJECT_ENDPOINT"] | ||
| agent_name = os.environ.get("FOUNDRY_HOSTED_AGENT_NAME", "MyHostedAgent") | ||
| model_name = os.environ["FOUNDRY_MODEL_NAME"] | ||
| teams_connection_name = os.environ["TEAMS_CONNECTION_NAME"] |
| print(response_text.encode("utf-8", errors="replace").decode("utf-8")) | ||
|
|
||
| print("Routines after scheduling the reminder:") | ||
| deadline = time.monotonic() + 30 |
…est, add new hosted agent samples for Teams message trigger and reminder preview
980ac10 to
78f5147
Compare
…est, add new hosted agent samples for Teams message trigger and reminder preview
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines