-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix tracing for operation id to flow in exception table. #47387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
harsheet-shah
wants to merge
16
commits into
Azure:main
Choose a base branch
from
harsheet-shah:user/harsheetshah/fix-telemetry-traceid
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+14
−4
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
1ba43a4
fix tracing for operation id to flow in exception table.
13ecc29
Fix OTel context lifecycle in tracing middleware
66ae7a2
Add test for safe deferred OTel detach
01c74fe
Revert "Add test for safe deferred OTel detach"
52a9c9b
Reset test_tracing.py to main
f4c618e
Harden deferred OTel detach callback
748d9f3
Simplify deferred detach path
836b042
Detach deferred OTel token safely
04ec5af
Add fallback when call_soon scheduling fails
98419e4
Reuse detach_context for deferred cleanup
3a8134a
Enrich logs with agent and session dimensions
950a618
Fix log enrichment fallback and drop sessionid dimension
5243eb2
Fix trace context detach and agent identity resolution
c0e39a3
Add AZURE_AI_* agent identity fallback
f2ab16b
Revert agent name/version fallback changes
ab46ec2
Revert agent name/version enrichment changes
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to create a non-recording span ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should validate consequent request and how traces show up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes @singankit I've validated pls check this query - https://ms.portal.azure.com#@72f988bf-86f1-41af-91ab-2d7cd011db47/blade/Microsoft_OperationsManagementSuite_Workspace/Logs.ReactView/resourceId/%2Fsubscriptions%2F47f1c914-e299-4953-a99d-3e34644cfe1c%2FresourceGroups%2Fharsheetrg%2Fproviders%2Fmicrosoft.insights%2Fcomponents%2Fharsheet-app-insights-debug/source/LogsBlade.AnalyticsShareLinkToQuery/q/H4sIAAAAAAAAA0utSE4tKMnMzyvmqlEoz0gtSlUoycxNLS5JzC1QsLNVKMlPSSxJBQlpqBsZGJnpGoBQiKGplZGJlYGBnoWZqZGxRZS6JlB7cX5RiUJSJZIBicXJAH4x9HdhAAAA/limit/1000
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to create a non-recording span ?--- I think line 288 internally does create non recording span