[Key Vault] Add default value for inner_error#46315
Merged
mccoyp merged 1 commit intoAzure:mainfrom Apr 14, 2026
Merged
Conversation
kashifkhan
approved these changes
Apr 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Key Vault Certificates public model CertificateOperationError to make its inner_error parameter optional by providing a default value of None, aligning runtime behavior with its type hint and preventing unnecessary instantiation errors when no inner error is present.
Changes:
- Add a default value (
None) for theinner_errorparameter inCertificateOperationError.__init__.
Member
Author
|
/check-enforcer override CI failures are unrelated, though they should be addressed soon in a different PR. |
Member
Author
|
/check-enforcer override |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#41965 handled the edge case where
inner_errorisNone, but didn't introduce a default value for the parameter; the model shouldn't be created by users, so the_from_error_bundlemethod should be the only place where aCertificateOperationErroris constructed. However, for consistency with the type hint and to prevent unnecessary errors, this adds a defaultNonevalue for the argument.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines