Skip to content

eng, bug fix in Compare-CurrentToCodegeneration.ps1 script#49328

Merged
weidongxu-microsoft merged 4 commits into
Azure:mainfrom
weidongxu-microsoft:increment-package-version-keyvault-6360407_fork
Jun 2, 2026
Merged

eng, bug fix in Compare-CurrentToCodegeneration.ps1 script#49328
weidongxu-microsoft merged 4 commits into
Azure:mainfrom
weidongxu-microsoft:increment-package-version-keyvault-6360407_fork

Conversation

@weidongxu-microsoft
Copy link
Copy Markdown
Member

@weidongxu-microsoft weidongxu-microsoft commented Jun 1, 2026

#49287 + fix a bug in Compare-CurrentToCodegeneration.ps1‎ script

bug is that there is possibility that a module be contained in 2 ServiceDirectories, e.g. keyvault,keyvault/azure-resourcemanager-keyvault -- here azure-resourcemanager-keyvault module would be processed twice, in parallel processes, likely causing race condition on file system, as 2 processes runs in the same folder
commit c531267
ref #49287 (comment)

now result is good
https://dev.azure.com/azure-sdk/public/_build/results?buildId=6376549&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=8dd92614-7454-569d-3061-0c20dc3c788d

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@weidongxu-microsoft
Copy link
Copy Markdown
Member Author

resolve conflict for #49287

@github-actions github-actions Bot added Azure SDK Tools Label for tracking issues related to Azure SDK Tools azure-spring All azure-spring related issues Azure.Core azure-core Azure.Identity KeyVault Mgmt This issue is related to a management-plane library. labels Jun 1, 2026
@weidongxu-microsoft weidongxu-microsoft marked this pull request as ready for review June 1, 2026 06:59
Copilot AI review requested due to automatic review settings June 1, 2026 06:59
@weidongxu-microsoft weidongxu-microsoft changed the title Increment package version keyvault 6360407 fork eng, bug fix in Compare-CurrentToCodegeneration.ps1 script Jun 1, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates Key Vault package versions across the repo (including version metadata and changelogs) and adjusts the Compare-CurrentToCodegeneration.ps1 script to normalize/deduplicate/sort ServiceDirectories so top-level service entries are processed before specific libraries (avoiding duplicate work when both are provided).

Changes:

  • Bump Key Vault Secrets and Certificates package versions (including new “Unreleased” changelog entries) and update eng/versioning/version_client.txt.
  • Update various repo consumers (Spring starters/autoconfigure, tooling, samples, e2e) to reference the latest released Key Vault versions (and update internal “current” references where appropriate).
  • Fix Compare-CurrentToCodegeneration.ps1 service directory handling by normalizing, deduplicating, ordering, and skipping redundant library paths when the top-level service is already included.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
sdk/tools/azure-openrewrite/pom.xml Updates Key Vault test/provided dependency versions to the latest released versions.
sdk/spring/spring-cloud-azure-starter-keyvault-secrets/pom.xml Bumps Key Vault Secrets dependency to 4.11.0.
sdk/spring/spring-cloud-azure-starter-keyvault-certificates/pom.xml Bumps Key Vault Certificates dependency to 4.9.0.
sdk/spring/spring-cloud-azure-service/pom.xml Updates optional Key Vault dependency versions (certificates/secrets).
sdk/spring/spring-cloud-azure-autoconfigure/pom.xml Updates optional Key Vault dependency versions (certificates/secrets).
sdk/spring/spring-cloud-azure-appconfiguration-config/pom.xml Bumps Key Vault Secrets dependency to 4.11.0.
sdk/spring/spring-cloud-azure-actuator/pom.xml Updates optional Key Vault dependency versions (certificates/secrets).
sdk/spring/spring-cloud-azure-actuator-autoconfigure/pom.xml Updates optional Key Vault dependency versions (certificates/secrets).
sdk/resourcemanager/azure-resourcemanager-samples/pom.xml Updates Key Vault Certificates dependency to 4.9.0.
sdk/network/azure-resourcemanager-network/pom.xml Updates Key Vault Certificates test dependency to 4.9.0.
sdk/keyvault/azure-security-keyvault-secrets/pom.xml Increments Key Vault Secrets package version to 4.12.0-beta.1.
sdk/keyvault/azure-security-keyvault-secrets/CHANGELOG.md Adds an “Unreleased” section for 4.12.0-beta.1.
sdk/keyvault/azure-security-keyvault-perf/pom.xml Updates “current” Key Vault dependency versions to the new beta versions.
sdk/keyvault/azure-security-keyvault-certificates/pom.xml Increments Key Vault Certificates package version to 4.10.0-beta.1.
sdk/keyvault/azure-security-keyvault-certificates/CHANGELOG.md Adds an “Unreleased” section for 4.10.0-beta.1.
sdk/keyvault/azure-resourcemanager-keyvault/pom.xml Updates Key Vault Secrets dependency to 4.11.0.
sdk/e2e/pom.xml Updates Key Vault “current” versions used by e2e module to the new beta versions.
sdk/core/azure-core-tracing-opentelemetry-samples/pom.xml Updates Key Vault Secrets test dependency to 4.11.0.
sdk/appplatform/azure-resourcemanager-appplatform/pom.xml Updates Key Vault Certificates test dependency to 4.9.0.
eng/versioning/version_client.txt Advances current/next versions for Key Vault certificates and secrets.
eng/scripts/Compare-CurrentToCodegeneration.ps1 Normalizes/deduplicates/sorts ServiceDirectories and skips redundant library entries when top-level service is present.

Comment thread eng/scripts/Compare-CurrentToCodegeneration.ps1
@weidongxu-microsoft weidongxu-microsoft merged commit e75209c into Azure:main Jun 2, 2026
66 checks passed
@github-project-automation github-project-automation Bot moved this from Untriaged to Done in Azure SDK for Key Vault Jun 2, 2026
@github-project-automation github-project-automation Bot moved this from Untriaged to Done in Azure Identity SDK Improvements Jun 2, 2026
@weidongxu-microsoft weidongxu-microsoft deleted the increment-package-version-keyvault-6360407_fork branch June 2, 2026 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure.Core azure-core Azure.Identity Azure SDK Tools Label for tracking issues related to Azure SDK Tools azure-spring All azure-spring related issues KeyVault Mgmt This issue is related to a management-plane library.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants