Skip to content

Adjust logging to avoid expensive CosmosException.getMessage() diagnostics json serialization #49321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaxpod70 wants to merge 2 commits into
base: main
Choose a base branch
from
+23 −6
Open

Adjust logging to avoid expensive CosmosException.getMessage() diagnostics json serialization #49321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ed6ce2
adjust logging to avoid expensive CosmosException.getMessage() on WAR…
May 29, 2026
751ec81
Merge branch 'main' into jmck/logging-0
jaxpod70 Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions ...in/java/com/azure/cosmos/implementation/changefeed/epkversion/PartitionProcessorImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,17 @@ public Mono<Void> run(CancellationToken cancellationToken) {

CosmosException clientException = (CosmosException) throwable;
logger.warn(
"Lease with token " + this.lease.getLeaseToken() + ": CosmosException was thrown from thread " +
Copy link
Copy Markdown
Member

@FabianMeiswinkel FabianMeiswinkel Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using ShortMessage is fine for possibly noisy logs - see Exceptions.isCommonlyExpectedExceptionPossiblyCausingNoisyLogs for an example - but for unexpected errors the full diagnostics are crucial for being able to debug - so, please use the Exceptions.isCommonlyExpectedExceptionPossiblyCausingNoisyLogs to decide whether to use full or short message

Thread.currentThread().getId() + " for lease with owner " + this.lease.getOwner(),
clientException);
"Lease with token {}: CosmosException was thrown from thread {} for lease with owner {} {}",
this.lease.getLeaseToken(),
Thread.currentThread().getId(),
this.lease.getOwner(),
clientException.getShortMessage());
Comment on lines +201 to +205
if (logger.isDebugEnabled()) {
logger.debug(
"Lease with token " + this.lease.getLeaseToken() + ": CosmosException was thrown from thread " +
Thread.currentThread().getId() + " for lease with owner " + this.lease.getOwner(),
clientException);
Comment on lines +207 to +210
}
StatusCodeErrorType docDbError =
ExceptionClassifier.classifyClientException(clientException);

Expand Down
15 changes: 12 additions & 3 deletions ...ain/java/com/azure/cosmos/implementation/changefeed/pkversion/PartitionProcessorImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,18 @@ public Mono<Void> run(CancellationToken cancellationToken) {
// we know it is a terminal event.

CosmosException clientException = (CosmosException) throwable;
logger.warn("CosmosException: Partition " + this.lease.getLeaseToken()
+ " from thread " + Thread.currentThread().getId() + " with owner " + this.lease.getOwner(),
clientException);
logger.warn(
"CosmosException: partition {} from thread {} with owner {} {}",
this.lease.getLeaseToken(),
Thread.currentThread().getId(),
this.lease.getOwner(),
clientException.getShortMessage());
Comment on lines +211 to +216
if (logger.isDebugEnabled()) {
logger.debug(
"CosmosException: partition" + this.lease.getLeaseToken()
+ "from thread " + Thread.currentThread().getId() + " with owner " + this.lease.getOwner(),
clientException);
Comment on lines +218 to +221
}
StatusCodeErrorType docDbError = ExceptionClassifier.classifyClientException(clientException);

switch (docDbError) {
Expand Down
Loading