Remove direct dependency on Azure SDK team hosted httpbin instance#7216
Merged
Conversation
… it is still used
Member
Author
|
/azp run cpp - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run cpp - core |
|
Azure Pipelines: Successfully started running 2 pipeline(s). 8 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Member
Author
|
/azp run cpp - core |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Member
Author
|
/azp run cpp - core |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
Azure Pipelines: Successfully started running 2 pipeline(s). 8 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the hard-coded dependency on the Azure SDK team-hosted httpbin endpoint in azure-core tests by switching to an environment-variable configured httpbin base URL, and conditionally skipping httpbin-dependent tests when it isn’t configured. It also updates developer documentation/spellchecking and adjusts CI coverage expectations accordingly.
Changes:
- Read the httpbin base URL from
AZSDKCPPTEST_HTTPBIN_URLand exposeIsEnabled()for tests to conditionally skip when not configured. - Add
GTEST_SKIP_()guards across multiple unit tests that previously assumed a fixed httpbin endpoint. - Document the new test configuration and update CI/code coverage thresholds and spellchecker dictionary.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/core/ci.yml | Lowers line coverage target after making some tests conditional on httpbin configuration. |
| sdk/core/azure-core/test/ut/transport_policy_options.cpp | Makes httpbin-dependent tests skippable when the env var isn’t configured. |
| sdk/core/azure-core/test/ut/transport_adapter_base_test.hpp | Introduces env-var parsing/logging for httpbin URL and IsEnabled() helper. |
| sdk/core/azure-core/test/ut/transport_adapter_base_test.cpp | Adds skip guards to many transport adapter tests to avoid hard-coded httpbin dependency. |
| sdk/core/azure-core/test/ut/curl_options_test.cpp | Adds skip guards for curl-related tests that depend on httpbin. |
| sdk/core/azure-core/test/ut/curl_connection_pool_test.cpp | Adds skip guards for curl connection pool tests that depend on httpbin. |
| sdk/core/azure-core/test/ut/azure_libcurl_core_main_test.cpp | Switches the libcurl “globalCleanUp” test off httpbin.org hardcoding and adds skip guard. |
| sdk/core/azure-core/README.md | Documents AZSDKCPPTEST_HTTPBIN_URL requirement for running httpbin-based tests. |
| .vscode/cspell.json | Adds AZSDKCPPTEST to the dictionary. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
LarryOsterman
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.