Skip to content

Remove direct dependency on Azure SDK team hosted httpbin instance#7216

Merged
antkmsft merged 17 commits into
Azure:mainfrom
antkmsft:httpbin
Jul 15, 2026
Merged

Remove direct dependency on Azure SDK team hosted httpbin instance#7216
antkmsft merged 17 commits into
Azure:mainfrom
antkmsft:httpbin

Conversation

@antkmsft

Copy link
Copy Markdown
Member

No description provided.

@antkmsft

Copy link
Copy Markdown
Member Author

/azp run cpp - core

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@antkmsft antkmsft reopened this Jul 14, 2026
@antkmsft

Copy link
Copy Markdown
Member Author

/azp run cpp - core

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).
8 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@antkmsft

Copy link
Copy Markdown
Member Author

/azp run cpp - core

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@antkmsft

Copy link
Copy Markdown
Member Author

/azp run cpp - core

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@antkmsft antkmsft changed the title Modify an in-house hosted httpbin URL so that tests will fail in case it is still used Remove direct dependency on Azure SDK team hosted httpbin instance Jul 15, 2026
@antkmsft antkmsft marked this pull request as ready for review July 15, 2026 17:30
@antkmsft antkmsft requested a review from RickWinter as a code owner July 15, 2026 17:30
Copilot AI review requested due to automatic review settings July 15, 2026 17:30
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).
8 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the hard-coded dependency on the Azure SDK team-hosted httpbin endpoint in azure-core tests by switching to an environment-variable configured httpbin base URL, and conditionally skipping httpbin-dependent tests when it isn’t configured. It also updates developer documentation/spellchecking and adjusts CI coverage expectations accordingly.

Changes:

  • Read the httpbin base URL from AZSDKCPPTEST_HTTPBIN_URL and expose IsEnabled() for tests to conditionally skip when not configured.
  • Add GTEST_SKIP_() guards across multiple unit tests that previously assumed a fixed httpbin endpoint.
  • Document the new test configuration and update CI/code coverage thresholds and spellchecker dictionary.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
sdk/core/ci.yml Lowers line coverage target after making some tests conditional on httpbin configuration.
sdk/core/azure-core/test/ut/transport_policy_options.cpp Makes httpbin-dependent tests skippable when the env var isn’t configured.
sdk/core/azure-core/test/ut/transport_adapter_base_test.hpp Introduces env-var parsing/logging for httpbin URL and IsEnabled() helper.
sdk/core/azure-core/test/ut/transport_adapter_base_test.cpp Adds skip guards to many transport adapter tests to avoid hard-coded httpbin dependency.
sdk/core/azure-core/test/ut/curl_options_test.cpp Adds skip guards for curl-related tests that depend on httpbin.
sdk/core/azure-core/test/ut/curl_connection_pool_test.cpp Adds skip guards for curl connection pool tests that depend on httpbin.
sdk/core/azure-core/test/ut/azure_libcurl_core_main_test.cpp Switches the libcurl “globalCleanUp” test off httpbin.org hardcoding and adds skip guard.
sdk/core/azure-core/README.md Documents AZSDKCPPTEST_HTTPBIN_URL requirement for running httpbin-based tests.
.vscode/cspell.json Adds AZSDKCPPTEST to the dictionary.

Comment thread sdk/core/azure-core/test/ut/transport_adapter_base_test.cpp
Comment thread sdk/core/azure-core/test/ut/transport_adapter_base_test.cpp
Comment thread sdk/core/azure-core/test/ut/transport_adapter_base_test.cpp Outdated
Comment thread sdk/core/azure-core/test/ut/transport_adapter_base_test.hpp
Comment thread sdk/core/azure-core/test/ut/transport_adapter_base_test.hpp
Comment thread sdk/core/azure-core/test/ut/transport_policy_options.cpp Outdated
Comment thread sdk/core/azure-core/test/ut/curl_options_test.cpp Outdated
Comment thread sdk/core/azure-core/test/ut/curl_connection_pool_test.cpp Outdated
Comment thread sdk/core/azure-core/test/ut/azure_libcurl_core_main_test.cpp Outdated
Comment thread sdk/core/ci.yml
antkmsft and others added 3 commits July 15, 2026 10:45
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@antkmsft antkmsft merged commit c24a402 into Azure:main Jul 15, 2026
85 checks passed
@antkmsft antkmsft deleted the httpbin branch July 15, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants