Add Azure PowerShell code review skill - #30028
Draft
ZelinWang (wangzelin007) wants to merge 2 commits into
Draft
Conversation
Copilot-Session: 3732a88d-f131-4633-ac86-77dd4543f31d
Contributor
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Member
|
/azp run |
Contributor
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a repository-level Copilot skill (azure-powershell-code-review) intended to guide consistent Azure PowerShell PR triage and review, with emphasis on generated/AutoRest workflows, release readiness, and cmdlet correctness checks.
Changes:
- Introduces a new code review skill document with a two-phase review workflow (triage + code review).
- Defines generated-module identification rules (TypeSpec vs Swagger) and related required artifacts/checks.
- Adds structured “Review Result” recommendations and comment-writing guidance.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+49
to
+53
| 1. Stop the normal ownership flow. | ||
| 2. Mark the PR for handoff to the Codegen Squad for TypeSpec migration. | ||
| 3. Contact Bernard Pan `<bernardpan@microsoft.com>`. | ||
| 4. Do not guess a GitHub username; resolve it before assigning. | ||
| 5. Resume normal review after the migration is complete. |
Copilot-Session: 3732a88d-f131-4633-ac86-77dd4543f31d
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (2)
.github/skills/code-review/SKILL.md:36
- The skill only treats
src/<ModuleName>/<SubModuleName>.Autorest/**as a generated-module indicator, but this repo also has generated AutoRest outputs undergenerated/<ModuleName>/<SubModuleName>.Autorest/**(e.g.,generated/Compute/Compute.Autorest). Without including thegenerated/pattern, triage will miss a large class of generated-module PRs.
Changes under:
```text
src/<ModuleName>/<SubModuleName>.Autorest/**
are changes to a generated module.
**.github/skills/code-review/SKILL.md:58**
* `Contributor PRs must not change generated/**` is stated as a hard rule here, but the repo’s documented contribution guidance doesn’t mention this restriction, and CI only warns about mixed `/src` + `/generated` changes (it doesn’t blanket-ban `generated/**`). Consider softening this to guidance (or linking to the authoritative policy) so reviewers don’t incorrectly block legitimate PRs.
Contributor PRs must not change generated/**, except:
- Protected-branch merge PRs.
- PRs titled
[skip ci] Archive ....
</details>
Member
|
/azp run |
Contributor
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Description
Adds a repository-level Copilot skill for reviewing Azure PowerShell pull requests.
The skill covers:
The repository version intentionally does not contain vendor lists or rules that skip reviews based on the PR author's identity.
Testing