[serviceconnector-passwordless] Fix postgres command argument name#10050
Open
avanigupta wants to merge 2 commits into
Open
[serviceconnector-passwordless] Fix postgres command argument name#10050avanigupta wants to merge 2 commits into
avanigupta wants to merge 2 commits into
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the serviceconnector-passwordless extension to stay compatible with a breaking change in the core Azure CLI Postgres module by switching the internal az postgres flexible-server db show argument from --database-name to --name, and bumps the extension version accordingly.
Changes:
- Update internal invocation of
az postgres flexible-server db showto use--nameinstead of--database-name. - Bump extension version to
3.3.7in bothsetup.pyand extension config. - Add a
3.3.7release note describing the compatibility fix.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/serviceconnector-passwordless/setup.py | Bumps extension package version to 3.3.7. |
| src/serviceconnector-passwordless/HISTORY.rst | Adds 3.3.7 changelog entry documenting the CLI argument update. |
| src/serviceconnector-passwordless/azext_serviceconnector_passwordless/config.py | Keeps extension runtime VERSION in sync at 3.3.7. |
| src/serviceconnector-passwordless/azext_serviceconnector_passwordless/_credential_free.py | Updates the internal az postgres flexible-server db show call to use --name. |
Collaborator
|
serviceconnector |
Member
Author
jimmyca15
approved these changes
Jun 29, 2026
xfz11
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated internal argument for
az postgres flexible-server db showcommand from--database-nameto--name.This was broken due to a recent breaking change in postgres CLI module: Azure/azure-cli#33343
This PR also pins the minimum CLI version to 2.87.0 - which contains the Postgres breaking change.
CLI Version pin instructions: https://github.com/Azure/azure-cli/blob/dev/doc/extensions/metadata.md
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (azdevrequired; see.azure-pipelines/templates/azdev_setup.ymlfor the install command untilazdev==0.2.11b1is on PyPI)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.