[Container Apps] Fix Azure/azure-cli-extensions#10016: az containerapp job create: Fix registry identity auth for ACR sovereign cloud domains#10017
Draft
Copilot wants to merge 2 commits into
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @copilot, |
…zurecr.us, azurecr.cn) for managed identity auth
Copilot
AI
changed the title
[WIP] Fix az containerapp job create registry auth for azurecr.us
[Container Apps] Fix Azure/azure-cli-extensions#10016: az containerapp job create: Fix registry identity auth for ACR sovereign cloud domains
Jun 22, 2026
Collaborator
|
Container Apps |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--registry-identityauth was rejected for*.azurecr.us(US Gov) and*.azurecr.cn(Azure China) ACR domains because all registry domain checks hardcoded.azurecr.ioonly.Changes
_constants.py: AddedACR_IMAGE_SUFFIXES = [".azurecr.io", ".azurecr.us", ".azurecr.cn"]_utils_validation.py: Addedis_acr_registry(server)— checks all three ACR sovereign cloud domains_utils.py: Re-exportsis_acr_registryfor consumers already importing from_utils_validators.py: ReplacedACR_IMAGE_SUFFIX not in (registry_server or "")withnot is_acr_registry(registry_server)invalidate_create— this was the direct error pathcontainerapp_decorator.py,containerapp_job_decorator.py,containerapp_job_registry_decorator.py,custom.py,_up_utils.py: Replaced allACR_IMAGE_SUFFIX in/not in serverchecks withis_acr_registry(); also fixedrindex(ACR_IMAGE_SUFFIX)calls in_up_utils.pythat wouldValueErrorfor non-.iodomainstests/latest/test_containerapp_validator_unit.py: Unit tests covering.azurecr.io,.azurecr.us,.azurecr.cn, and non-ACR registriesBefore / After
Related command
az containerapp create,az containerapp update,az containerapp job create,az containerapp registry setGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (azdevrequired; see.azure-pipelines/templates/azdev_setup.ymlfor the install command untilazdev==0.2.11b1is on PyPI)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.