Skip to content

feat: export/publish built-in managed gateway apis - #515

Open
David Schneiderbauer (daviian) wants to merge 1 commit into
Azure:mainfrom
daviian:managed-gateway
Open

feat: export/publish built-in managed gateway apis#515
David Schneiderbauer (daviian) wants to merge 1 commit into
Azure:mainfrom
daviian:managed-gateway

Conversation

@daviian

@daviian David Schneiderbauer (daviian) commented Mar 29, 2024

Copy link
Copy Markdown
Contributor

resolves #501

@daviian

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree company="Cloudflight"

@waelkdouh

Copy link
Copy Markdown
Contributor

Hi we just released v6 release candidate. Can you please try to apply your PR on the new code base?

@waelkdouh

Copy link
Copy Markdown
Contributor

David Schneiderbauer (@daviian) will you be able to resubmit the PR against the new v6 code base?

@daviian

Copy link
Copy Markdown
Contributor Author

Wael Kdouh (@waelkdouh) I'll try to find some time this week to check out the new code base and apply my changes.

@daviian

David Schneiderbauer (daviian) commented Jul 10, 2024

Copy link
Copy Markdown
Contributor Author

Wael Kdouh (@waelkdouh) I need some clarification about this line https://github.com/Azure/apiops/blob/main/tools/code/publisher/App.cs#L51.
Isn't the order important when importing changed files? As in, you cannot assign a gateway to an API that has not yet been created before.
How is this ensured in v6?

I think I've found the answer.
Please let me know if the solution is fine or needs changes.

@daviian
David Schneiderbauer (daviian) force-pushed the managed-gateway branch 2 times, most recently from c384212 to c1a3b0e Compare July 10, 2024 11:30
@daviian
David Schneiderbauer (daviian) force-pushed the managed-gateway branch 4 times, most recently from 89d9b9c to 1ec4b7a Compare August 7, 2024 14:07
@daviian

Copy link
Copy Markdown
Contributor Author

I've updated the PR so that the conflicts from recent merges have been resolved.
guythetechie can you have a look at the PR please?

@daviian
David Schneiderbauer (daviian) force-pushed the managed-gateway branch 2 times, most recently from b1725b7 to 37e5985 Compare August 23, 2024 06:13
@daviian

Copy link
Copy Markdown
Contributor Author

Is there any chance this can be removed soonish?

@glenroy37

Copy link
Copy Markdown

Is there any timeframe when this will be reviewed and merged? We currently have to build the apiops publisher manually with the changes from this PR and it seems to be abandoned for nearly a year now

@waelkdouh

Copy link
Copy Markdown
Contributor

Anna Teier (@glenroy37) Let me take a look and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Question] How to not include "Managed" gateway by default when publishing APIs

3 participants