Draft
fix: deep-merge nested file-only properties in mergeJsonParameters#9419
Conversation
Copilot
AI
changed the title
[WIP] Fix the code as per review comment
fix: deep-merge nested file-only properties in mergeJsonParameters
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mergeJsonParametersonly performed a shallow merge, so file-only nested fields (e.g.metadata.description,properties.someField) were silently dropped whenever the parent key already existed in the designer output.Changes
openDesignerForLocalProject.tsdeepMergeFileProperties(source, target)— recursively walkssource(file param), copying absent properties intotarget(designer param) and recursing into nested plain objectsisPlainObjectguard to correctly handle arrays as opaque values (designer wins)mergeJsonParametersto calldeepMergeFilePropertiesinstead of the old top-level-only loopCommit Type
Risk Level
What & Why
mergeJsonParametersshallow-merged parameters from the file into the designer output, only backfilling missing top-level properties. Nested file-only fields under an existing key (e.g.metadata,properties) were dropped. Replaced the shallow loop with a recursive deep-merge that preserves file-only fields at every nesting level while keeping designer values as the authoritative source.Impact of Change
metadata, custom nested properties) set inparameters.jsonare no longer silently dropped on saveTest Plan
Contributors
Screenshots/Videos