fix: throw on missing accessToken instead of returning "******"

[Copilot]

getAuthorizationToken used a bare template literal ****** with no null-guard, silently returning "******"` when no session token was available. This invalid header value was being baked into tests as expected behavior and could propagate to downstream ARM requests via the new periodic token-refresh path.

Changes

getAuthorizationToken.ts

• Added guard: if authData?.accessToken is falsy, throw a localized error instead of producing "******"
• Return type remains Promise<string> — no callers require updates

export async function getAuthorizationToken(tenantId?: string): Promise<string> {
  const authData = await getAuthData(tenantId);
  if (!authData?.accessToken) {
    throw new Error(localize('noAccessToken', 'No access token available. Please sign in to Azure.'));
  }
  return `******;
}

__test__/getAuthorizationToken.test.ts (new)

• Added unit tests for getAuthorizationToken, getAuthorizationTokenFromNode, and getCloudHost
• The previously-broken test that asserted '******' as the expected return value now correctly asserts a throw with the specific error message

Commit Type

• feature - New functionality
• fix - Bug fix
• refactor - Code restructuring without behavior change
• perf - Performance improvement
• docs - Documentation update
• test - Test-related changes
• chore - Maintenance/tooling

Risk Level

• Low - Minor changes, limited scope
• Medium - Moderate changes, some user impact
• High - Major changes, significant user/system impact

What & Why

Guards against getAuthorizationToken returning "******" when no access token is available. The bug was introduced silently via an unguarded template literal; the companion test was asserting the broken behavior rather than catching it.

Impact of Change

• Users: Auth failures become explicit errors rather than silent invalid-header sends
• Developers: getAuthorizationToken now throws if the session has no accessToken; callers already in try/catch (e.g. the periodic refresh in openDesignerForLocalProject) are unaffected
• System: No performance or dependency changes

Test Plan

• Unit tests added/updated
• E2E tests added/updated
• Manual testing completed
• Tested in: unit test suite (apps/vs-code-designer — 1348 tests pass)

Contributors

Screenshots/Videos