Bugfix: 1385: Authentication fails if both date and x-ms-date headers are present - #2316
Open
BillBooks wants to merge 1 commit into
Open
Bugfix: 1385: Authentication fails if both date and x-ms-date headers are present#2316BillBooks wants to merge 1 commit into
BillBooks wants to merge 1 commit into
Conversation
specified For queues and blobs, when forming the shared key token, the Date header should be treated as the empty string when the x-ms-date header is present. For tables, the value of the x-ms-date header shoudl be used as the value of the Date header if teh x-ms-date header is present. This behavior is documented at https://learn.microsoft.com/en-us/rest/api/storageservices/authorize-with-shared-key
Wei Wei (blueww)
suggested changes
Dec 8, 2023
Wei Wei (blueww)
left a comment
Wei Wei (blueww)
left a comment
Contributor
There was a problem hiding this comment.
The change generally looks good to me.
It's better to also add test cases for blob/Queue servicce.
BillBooks
changed the title
BillBooks
changed the title
Author
|
I'll look at adding some tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For queues and blobs, when forming the shared key token, the Date header should be treated as the empty string when the x-ms-date header is present.
For tables, the value of the x-ms-date header should be used as the value of the Date header if the x-ms-date header is present.
This behavior is documented at
https://learn.microsoft.com/en-us/rest/api/storageservices/authorize-with-shared-key