Fix Fortinet DNS parser default event type filtering - #14958
Open
michaelatmsft wants to merge 2 commits into
Open
Fix Fortinet DNS parser default event type filtering#14958michaelatmsft wants to merge 2 commits into
michaelatmsft wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 49c1ced3-80e6-49d1-9097-625db490ea0d
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 49c1ced3-80e6-49d1-9097-625db490ea0d
Contributor
Author
CI status after rerunAll current checks pass except The rerun confirms the behavior fixed here: invoking the modified parser with its
KQL validation passed on rerun, as did ASIM template validation, sample-data ingestion, and schema/data validation. No failure identifies the changed Fortinet filter or generated ARM template as invalid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Fortinet FortiGate DNS filtering parser so the parameterless DNS unifying parser returns Fortinet DNS events.
_Im_Dns()uses the legacy defaulteventtype='lookup'and passes it to each source-specific filtering parser. Fortinet DNS events are normalized withEventType='Query', butvimDnsFortinetFortiGateonly acceptedQueryor*. As a result:excluded Fortinet DNS records, while either of these returned them:
This causes incomplete results for investigations, hunting queries, workbooks, analytics, and detections that use the ASIM DNS abstraction without overriding
eventtype.Root cause and regression history
Queryvalue and legacylookupvalue.7a88704015f888f441b3ccf9628f2da0a3c45c2a, replaced that check with a direct comparison betweenEventTypeTmp='Query'and the incoming parameter. This unintentionally removedlookupcompatibility and reintroduced the issue.Changing the unifying parser default from
lookuptoQueryis not safe because other DNS source parsers still rely on the legacy value. Compatibility therefore belongs in the source-specific filtering parser.Changes
Query, legacylookup, and*invimDnsFortinetFortiGate.lookup, matching the value supplied byimDnsand_Im_Dns.lookupsupport must not be removed.Regression coverage
The repository already runs an ASIM filtering workflow against Fortinet sample data. Using
lookupas this parser's default makes that workflow exercise the same path used by a parameterless_Im_Dns()call, providing regression coverage without adding new test infrastructure or a parser-specific test framework.Validation
lookupdefault, demonstrating that this regression is fixed. On both attempts, the job then failed its generic time-window assertions because all newly ingested sample rows had effectively the same timestamp (starttimereturned 21 of 21 rows andendtimereturned 0). It also reported the expected single DNSEventTypeas the workflow's documented partial-validation case. These failures are in the generic data-dependent test assumptions rather than the Fortinet event-type compatibility behavior changed by this PR.