A multi-account CCF candidate for Semperis Lightning - #14949
A multi-account CCF candidate for Semperis Lightning#14949sravansemperis wants to merge 4 commits into
Conversation
Review notes from live deploy (workspace test)Two issues showed up when installing this PR’s package ( 1.
|
| Field | Current PR | Needed |
|---|---|---|
offerId |
semperis-sentinel-lightning-ccf |
azure-sentinel-solution-semperislightning |
| Connectors | CCF only | Azure Functions (*_CL) and CCF (*V2_CL) |
| CCF title | multi-instance CCF candidate | Semperis Lightning (via Codeless Connector Framework) |
| Version | 4.0.2 | 4.1.0 (minor — new connector on existing offer) |
TemplateSpec |
false |
true (matches the live Function App solution) |
We validated a merged 4.1.0 package locally (ARM-TTK / solution validators passed) and deployed it to a test workspace. Happy to share the exact file diffs if useful.
I cannot push to sravansemperis/Azure-Sentinel from here — please apply the two changes above on this branch, or grant write / open a follow-up commit.
|
Follow-up after a successful portal Connect test of the merged 4.1.0 package. Please apply these changes on this PR (we cannot push to
Tested reference (do not merge this fork PR): |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a new Semperis Lightning Codeless Connector Framework (CCF) multi-instance / multi-account solution package for Microsoft Sentinel, including deployment templates, UI definition, connector configs, and custom table schemas.
Changes:
- Introduces solution metadata + release notes and solution “Data” manifest.
- Adds ARM package artifacts (mainTemplate, createUiDefinition, testParameters) to deploy connector definition, pollers, DCR, and tables.
- Adds connector source assets (poller config, DCR, connector definition, table schemas) plus an “unsupported capabilities” documentation file.
Reviewed changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| Solutions/SemperisLightningCCF/SolutionMetadata.json | Defines offer/solution metadata (publisher, version, support, categories). |
| Solutions/SemperisLightningCCF/ReleaseNotes.md | Adds version history/release notes for the solution. |
| Solutions/SemperisLightningCCF/Package/testParameters.json | Adds ARM TTK-friendly test parameter definitions. |
| Solutions/SemperisLightningCCF/Package/mainTemplate.json | Adds full deployable ARM template for connector definition, pollers, DCR, and tables. |
| Solutions/SemperisLightningCCF/Package/createUiDefinition.json | Adds installer UI definition (workspace selection + outputs). |
| Solutions/SemperisLightningCCF/MULTI-ACCOUNT.md | Adds multi-account setup/notes documentation. |
| Solutions/SemperisLightningCCF/Data/Solution_SemperisLightningCCF.json | Registers the solution manifest and points to connector assets. |
| Solutions/SemperisLightningCCF/Data Connectors/SemperisLightning_CCF/unsupported-capabilities.json | Documents inactive/partial streams and assumptions (auth/pagination). |
| Solutions/SemperisLightningCCF/Data Connectors/SemperisLightning_CCF/table_LightningTier0NodesV2_CL.json | Defines V2 custom table schema for Tier0 nodes. |
| Solutions/SemperisLightningCCF/Data Connectors/SemperisLightning_CCF/table_LightningTier0AttackersV2_CL.json | Defines V2 custom table schema for Tier0 attackers. |
| Solutions/SemperisLightningCCF/Data Connectors/SemperisLightning_CCF/table_LightningIndicatorExecutionsV2_CL.json | Defines V2 custom table schema for indicator executions. |
| Solutions/SemperisLightningCCF/Data Connectors/SemperisLightning_CCF/table_LightningIOEsMetadataV2_CL.json | Defines V2 custom table schema for IOE metadata. |
| Solutions/SemperisLightningCCF/Data Connectors/SemperisLightning_CCF/table_LightningIOEResultsV2_CL.json | Defines V2 custom table schema for IOE results. |
| Solutions/SemperisLightningCCF/Data Connectors/SemperisLightning_CCF/table_LightningAttackPathsV2_CL.json | Defines V2 custom table schema for attack paths. |
| Solutions/SemperisLightningCCF/Data Connectors/SemperisLightning_CCF/table_LightningAttackPathLinksV2_CL.json | Defines V2 custom table schema for attack path links. |
| Solutions/SemperisLightningCCF/Data Connectors/SemperisLightning_CCF/SemperisLightning_PollerConfig.json | Defines multi-instance poller resources and addOnAttributes. |
| Solutions/SemperisLightningCCF/Data Connectors/SemperisLightning_CCF/SemperisLightning_DCR.json | Defines DCR stream declarations + transforms for all streams. |
| Solutions/SemperisLightningCCF/Data Connectors/SemperisLightning_CCF/SemperisLightning_ConnectorDefinition.json | Defines the customizable data connector UX (grid + context pane). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Addressed the Copilot review comments on the tested 4.1.0 reference, and included the existing-offer merge (Function App + CCF).
Also on that branch (not in this PR yet):
Please pull these into this PR — we cannot push |
Change(s):
Added Semperis Lightning CCF multi account
Reason for Change(s):
Adding Semperis Lightning CCF multi account (New solution)
Version Updated:
No (Initial Version)
Testing Completed:
Testing done in Semperis tenant