Fix malformed dataCollectionEndpoint expression in dcrConfig - #14943
Open
chkp-kirilll wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes malformed nested ARM expression escaping that caused fresh Connect deployments to fail for the Check Point Cyberint Alerts/IOC codeless connectors, and bumps solution versions accordingly.
Changes:
- Reverted inner/nested ARM expression escaping from
[[expr]]to[[expr]across templates and polling configs to remove the stray trailing]. - Bumped solution/package versions (Alerts 3.1.3, IOC 3.0.5) across main templates and solution metadata.
- Updated release notes to document the fix.
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Solutions/Check Point Cyberint IOC/ReleaseNotes.md | Adds 3.0.5 entry documenting the ARM escaping fix. |
| Solutions/Check Point Cyberint IOC/Package/mainTemplate.json | Bumps versions and fixes nested template escaping that broke Connect-time deployments. |
| Solutions/Check Point Cyberint IOC/Data/Solution_Cyberint.json | Bumps solution version to 3.0.5. |
| Solutions/Check Point Cyberint IOC/Data Connectors/CyberintArgosIOCLogs_ccp/CyberintArgosIOCLogs_PollingConfig.json | Fixes escaped parameter expression in polling config. |
| Solutions/Check Point Cyberint Alerts/ReleaseNotes.md | Adds 3.1.3 entry documenting the ARM escaping fix. |
| Solutions/Check Point Cyberint Alerts/Package/mainTemplate.json | Bumps versions/descriptions and fixes nested template / playbook expression escaping. |
| Solutions/Check Point Cyberint Alerts/Data/Solution_Cyberint.json | Bumps solution version to 3.1.3. |
| Solutions/Check Point Cyberint Alerts/Data Connectors/CyberintArgosAlertsLogs_ccp/CyberintArgosAlertsLogs_PollingConfig.json | Fixes escaped expressions in polling config. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Hi chkp-kirilll Kindly attach the CCF testing screenshot to verify the implemented changes. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Change(s)
"[[expr]]"back to"[[expr]"(double opening bracket, single closing bracket) across both solutions:Check Point Cyberint Alerts/Package/mainTemplate.json(190 expressions)Check Point Cyberint Alerts/Data Connectors/CyberintArgosAlertsLogs_ccp/CyberintArgosAlertsLogs_PollingConfig.json(4 expressions)Check Point Cyberint IOC/Package/mainTemplate.json(7 expressions)Check Point Cyberint IOC/Data Connectors/CyberintArgosIOCLogs_ccp/CyberintArgosIOCLogs_PollingConfig.json(1 expression)Data/Solution_*.json).ReleaseNotes.mdfor both solutions.Package/3.1.3.zipandPackage/3.0.5.zip.No functional changes to connector polling logic, DCR/table schemas, playbooks, or UI definitions - the diff is exclusively the removal of one stray
]per affected expression, plus version metadata.Reason for Change(s)
A fresh install of Check Point Cyberint Alerts Connector (via Codeless Connector Platform) v3.1.2 from the Content Hub fails at the "Connect" step of the data connector wizard :
Root cause: v3.1.2 shipped inner contentTemplate expressions escaped as
"[[expr]]". ARM's escape rule strips only the leading[, so the stored template contains the literal[expr]]. When the Connect wizard deploys the storedResourcesDataConnectortemplate, ARM parses that as an expression with a trailing]and fails. The correct convention - used by all published CCP solutions (e.g. 1Password, AWS ELB, 42Crunch) and by the V3 packaging tool - is"[[expr]".The Cyberint IOC solution v3.0.4 shipped with the same defect in its polling config and would fail identically on a fresh Connect; it is fixed in the same way here.
The defect only affects the Connect-time deployment. Solution installation succeeds (the broken string is stored, not evaluated), and connectors connected under earlier versions keep polling - which is why the regression surfaced only on clean installs.
Version updated
3.1.3(mainTemplate_solutionVersion, contentPackage metadata,Data/Solution_Cyberint.json, ReleaseNotes, package zip)3.0.5(same set)Testing completed
ResourcesDataConnectorcontentTemplate stored on a workspace by the v3.1.2 package failsaz deployment group validatewith the exact reported error (expected token 'EndOfData' and actual 'RightSquareBracket').[[→[unescape ARM performs at install time - passesaz deployment group validateagainst a real Log Analytics workspace with identical parameters (provisioningState: Succeeded).]; no other content changed.Checklist