Migrate DNS playbook to Logs Ingestion API - #14934
Open
v-sabiraj wants to merge 2 commits into
Open
Conversation
Replace the Data Collector connection with DCE/DCR-based custom-table ingestion authenticated by the playbook managed identity.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Migrates the DNS Essentials summarization playbook from Log Analytics Data Collector API ingestion to DCE/DCR-based Logs Ingestion API using the playbook’s managed identity.
Changes:
- Added Data Collection Endpoint (DCE), Data Collection Rule (DCR), and custom tables to support Logs Ingestion API.
- Updated playbook actions from
ApiConnection(Data Collector) toHttpwith managed identity authentication. - Added RBAC role assignment for the playbook identity on the DCR and updated solution release notes/versioning.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+210
to
+214
| "defaultValue": "[concat(reference(resourceId('Microsoft.Insights/dataCollectionEndpoints', variables('DCEName'))).logsIngestion.endpoint, '/dataCollectionRules/', reference(resourceId('Microsoft.Insights/dataCollectionRules', variables('DCRName'))).immutableId, '/streams/', variables('ipStreamName'), '?api-version=2023-01-01')]", | ||
| "type": "string" | ||
| }, | ||
| "SourceInfoIngestionEndpoint": { | ||
| "defaultValue": "[concat(reference(resourceId('Microsoft.Insights/dataCollectionEndpoints', variables('DCEName'))).logsIngestion.endpoint, '/dataCollectionRules/', reference(resourceId('Microsoft.Insights/dataCollectionRules', variables('DCRName'))).immutableId, '/streams/', variables('sourceInfoStreamName'), '?api-version=2023-01-01')]", |
Comment on lines
606
to
610
| "apiVersion": "2019-05-01", | ||
| "dependsOn": [ | ||
| "[resourceId('Microsoft.Web/connections', variables('AzureloganalyticsdatacollectorConnectionName'))]", | ||
| "[resourceId('Microsoft.Insights/dataCollectionRules', variables('DCRName'))]", | ||
| "[resourceId('Microsoft.Web/connections', variables('AzuremonitorlogsConnectionName'))]" | ||
| ] |
Comment on lines
21
to
25
| "version": "2.0", | ||
| "title": "SummarizeDNSData", | ||
| "notes": [ | ||
| "Initial version" | ||
| "Migrated custom table ingestion from the Data Collector API to the Logs Ingestion API." | ||
| ] |
Comment on lines
+76
to
+79
| "description": "Data collection endpoint for DNS Essentials summarized logs", | ||
| "networkAcls": { | ||
| "publicNetworkAccess": "Enabled" | ||
| } |
v-atulyadav
added
Playbook
Reverted SummarizeData_DNSEssentials playbook to use the Azure Log Analytics Data Collector API for custom table ingestion instead of the Logs Ingestion API. Added a new SummarizeData_DNSEssentials_Logingestionapi playbook containing the previous Logs Ingestion API implementation (with DCE/DCR resources and managed identity auth) as a separate variant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the Data Collector connection with DCE/DCR-based custom-table ingestion authenticated by the playbook managed identity.
Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present:
Guidance <- remove section before submitting
Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.
Change(s):
Reason for Change(s):
Version updated:
Testing Completed:
Note: If updating a detection, you must update the version field.
Checked that the validations are passing and have addressed any issues that are present:
Note: Let us know if you have tried fixing the validation error and need help.