feat(ci): run next-net, benches and scenarios from public v6 nightlies#24727
Open
PhilWindle wants to merge 1 commit into
Open
feat(ci): run next-net, benches and scenarios from public v6 nightlies#24727PhilWindle wants to merge 1 commit into
PhilWindle wants to merge 1 commit into
Conversation
## What Restores a **public v6 nightly** and repoints the nightly consumers (next-net deploy, spartan benches, ci3 scenario tests) at it. Also fixes the bench-inclusion-sweep validation error. ## Why After `next` bumped to 6.0.0 and `v5-next` split off (release-machinery port, `7ac407c909`), the public repo: - narrowed nightly **tagging** to `v5-next` only → no public `6.0.0-nightly` image was ever built (`aztecprotocol/aztec:6.0.0-nightly.*` = 404), and - gated every **consumer** (next-net, spartan benches, ci3 `ci-network-scenario`) to `aztec-packages-private` + the internal registry. Net effect: from the public side, nightly deploys/tests/benches looked stopped. The public repo still published `v5.0.0-nightly` daily, but nothing public produced or consumed a v6 nightly. ## Changes - **`nightly-release-tag.yml`** — public repo now tags `next` (v6) as well as `v5-next`. The tag push runs `ci-release`, which publishes `aztecprotocol/aztec:6.0.0-nightly` (the public `release` path has no v5 gate). - **`deploy-next-net.yml`** — public-gated; derives the version from `next`'s manifest; `wait-for-ci3` blocks on the release build; deploys the public image (dropped `use_internal_docker_registry`). - **`nightly-spartan-bench.yml`** — private→public gates; checks out `next`; public registry; added a `wait-for-ci3` gate so the three deploy tracks don't race the release build (replaces the point-in-time image-existence check). - **`ci3.yml`** (`ci-network-scenario`) — gate flipped to `aztec-packages` and `v6.`, so nightly scenario tests run in the public repo on the v6 tag (runs inside the tag's ci3 run, gated on the release job). - **delete `nightly-release-tag-v5-next.yml`** — redundant now that the matrix tags `v5-next` in the public repo. - **`nightly-bench-inclusion-sweep.yml`** — pass `skip_notify_on_failure: true` (the renamed `deploy-network` input) instead of the removed `notify_on_failure`, fixing the "Invalid input" workflow error. ## Notes / side effects - v6 nightly now publishes publicly to **DockerHub _and_ npmjs/crates.io** (same as v5 today) — inherent to publishing a public v6 nightly. - `weekly-proving-bench.yml` needs no change — it already targets `next`+public, so it starts working once the v6 image publishes. - Scenario tests now run on **v6 only**; v5 is still deployed via `deploy-staging-*` but no longer scenario-tested nightly. - Worth confirming the public repo's `GCP_SA_KEY` can deploy next-net to `CLUSTER=aztec-gke-private` (staging-public deploys fine from public creds). Co-authored-by: Phil Windle <philip.windle@gmail.com>
e896878 to
b6de112
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Restores a public v6 nightly and repoints the nightly consumers (next-net deploy, spartan benches, ci3 scenario tests) at it. Also fixes the bench-inclusion-sweep validation error.
Why
After
nextbumped to 6.0.0 andv5-nextsplit off (release-machinery port,7ac407c909), the public repo:v5-nextonly → no public6.0.0-nightlyimage was ever built (aztecprotocol/aztec:6.0.0-nightly.*= 404), andci-network-scenario) toaztec-packages-private+ the internal registry.Net effect: from the public side, nightly deploys/tests/benches looked stopped. The public repo still published
v5.0.0-nightlydaily, but nothing public produced or consumed a v6 nightly.Changes
nightly-release-tag.yml— public repo now tagsnext(v6) as well asv5-next. The tag push runsci-release, which publishesaztecprotocol/aztec:6.0.0-nightly(the publicreleasepath has no v5 gate).deploy-next-net.yml— public-gated; derives the version fromnext's manifest;wait-for-ci3blocks on the release build; deploys the public image (droppeduse_internal_docker_registry).nightly-spartan-bench.yml— private→public gates; checks outnext; public registry; added await-for-ci3gate so the three deploy tracks don't race the release build (replaces the point-in-time image-existence check).ci3.yml(ci-network-scenario) — gate flipped toaztec-packagesandv6., so nightly scenario tests run in the public repo on the v6 tag (runs inside the tag's ci3 run, gated on the release job).nightly-release-tag-v5-next.yml— redundant now that the matrix tagsv5-nextin the public repo.nightly-bench-inclusion-sweep.yml— passskip_notify_on_failure: true(the renameddeploy-networkinput) instead of the removednotify_on_failure, fixing the "Invalid input" workflow error.Notes / side effects
weekly-proving-bench.ymlneeds no change — it already targetsnext+public, so it starts working once the v6 image publishes.deploy-staging-*but no longer scenario-tested nightly.GCP_SA_KEYcan deploy next-net toCLUSTER=aztec-gke-private(staging-public deploys fine from public creds).