chore: bump noir to 1.0.0-beta.23#24725
Open
AztecBot wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the
noir/noir-reposubmodule (the pinned Noir compiler) from 1.0.0-beta.22 to 1.0.0-beta.23, plus the knock-on source changes required to build against beta.23.noir/noir-repo:c57152f9(beta.22) →bd01f81e(v1.0.0-beta.23, noir-lang/noir#12862)Knock-on changes (verified locally with the beta.23
nargo)avm-transpiler — beta.23 made two ACIR tuple-struct fields private:
BrilligOpcodeLocation/BrilligFunctionId: use::new(…)/.index()accessors instead of tuple construction/field access.Cargo.lock: noir crates1.0.0-beta.22→1.0.0-beta.23.noir-projects/aztec-nr:
oracle_testing.nr: beta.23 rejects splicing a comptimefnvalue into runtime code. The scalar test-value builders now store the lambda as source tokens with a pinned return type (mirroring the existingbuilder_exprpath), with fully-qualified type/trait paths so they resolve at the generated test site.use std::panic;(now prelude) indispatch.nr/events.nr.noir-projects/noir-protocol-circuits (compiles clean with
--deny-warningsacross all 52 workspace members):BoundedVec::from_parts_unchecked→from_parts(deprecated in beta.23; the two are now identical). 42 call sites.types: silence unusedpackedin the empty-structPackable::unpackderive branch; unusedis_variable_lengthparam inposeidon2.nr.rollup-lib: drop unusedposeidon2_hashimport.Remaining (build-derived — will come from CI)
yarn-project/aztec/src/{mainnet,testnet}_compatibility.test.ts: expected VK-tree root / protocol-contracts hash / genesis roots change with the compiler bump; the exact values come from the CI build.yarn-project/yarn.lock: noir-* package versions +@aztec/noir-noir_jsfile:hash refresh.noir-contractsmay surface additional--deny-warningslint knock-ons under a full contract build.Note: requested independently of the private-branch merge —
noir-protocol-circuitsonnextdoes not yet contain anoir-bignumlibrary crate.