Skip to content

chore: bump noir to 1.0.0-beta.23#24725

Open
AztecBot wants to merge 4 commits into
nextfrom
cb/bump-noir-beta23
Open

chore: bump noir to 1.0.0-beta.23#24725
AztecBot wants to merge 4 commits into
nextfrom
cb/bump-noir-beta23

Conversation

@AztecBot

@AztecBot AztecBot commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Bumps the noir/noir-repo submodule (the pinned Noir compiler) from 1.0.0-beta.22 to 1.0.0-beta.23, plus the knock-on source changes required to build against beta.23.

Knock-on changes (verified locally with the beta.23 nargo)

avm-transpiler — beta.23 made two ACIR tuple-struct fields private:

  • BrilligOpcodeLocation / BrilligFunctionId: use ::new(…) / .index() accessors instead of tuple construction/field access.
  • Cargo.lock: noir crates 1.0.0-beta.221.0.0-beta.23.

noir-projects/aztec-nr:

  • oracle_testing.nr: beta.23 rejects splicing a comptime fn value into runtime code. The scalar test-value builders now store the lambda as source tokens with a pinned return type (mirroring the existing builder_expr path), with fully-qualified type/trait paths so they resolve at the generated test site.
  • Removed redundant use std::panic; (now prelude) in dispatch.nr / events.nr.

noir-projects/noir-protocol-circuits (compiles clean with --deny-warnings across all 52 workspace members):

  • BoundedVec::from_parts_uncheckedfrom_parts (deprecated in beta.23; the two are now identical). 42 call sites.
  • types: silence unused packed in the empty-struct Packable::unpack derive branch; unused is_variable_length param in poseidon2.nr.
  • rollup-lib: drop unused poseidon2_hash import.

Remaining (build-derived — will come from CI)

  • yarn-project/aztec/src/{mainnet,testnet}_compatibility.test.ts: expected VK-tree root / protocol-contracts hash / genesis roots change with the compiler bump; the exact values come from the CI build.
  • yarn-project/yarn.lock: noir-* package versions + @aztec/noir-noir_js file: hash refresh.
  • noir-contracts may surface additional --deny-warnings lint knock-ons under a full contract build.

Note: requested independently of the private-branch merge — noir-protocol-circuits on next does not yet contain a noir-bignum library crate.

@AztecBot AztecBot added ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR. labels Jul 15, 2026
@TomAFrench TomAFrench marked this pull request as ready for review July 15, 2026 09:00
@AztecBot AztecBot requested a review from nventuro as a code owner July 15, 2026 09:28
@AztecBot AztecBot requested a review from LeilaWang as a code owner July 15, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant