fix: bind deployment history proofs to canonical init hash#24724
Draft
AztecBot wants to merge 1 commit into
Draft
fix: bind deployment history proofs to canonical init hash#24724AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The deployment history helpers derived the initialization nullifier from a caller-supplied
init_hash. A caller could pass a non-canonical hash and prove non-inclusion of a different nullifier, so this change checks the supplied hash against the canonical contract instance before either history proof derives the nullifier.Fix
init_hashto matchget_contract_instance(contract_address).initialization_hashin both initialization history helpers.Testing
../../noir/noir-repo/target/debug/nargo test --package noir_aztec --exact history::deployment::test::assert_contract_was_not_initialized_by_rejects_noncanonical_init_hash --silence-warnings --test-threads 1failed before the fix withTest passed when it should have failed../../noir/noir-repo/target/debug/nargo test --package noir_aztec --exact history::deployment::test::assert_contract_was_not_initialized_by_rejects_noncanonical_init_hash --silence-warnings --test-threads 1../../noir/noir-repo/target/debug/nargo fmt --package noir_aztec/home/aztec-dev/aztec-packages/noir/noir-repo/target/debug/nargo fmt --package test_contract../../noir/noir-repo/target/debug/nargo test --package noir_aztec --no-run --silence-warnings/home/aztec-dev/aztec-packages/noir/noir-repo/target/debug/nargo test --package test_contract --no-run --silence-warningsgit diff --checkIssues
Created by claudebox · group:
kernels-audit-remediation