test: cover checkpoint boundary variants#24723
Draft
AztecBot wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The checkpoint/root variant tests missed several legal boundary cases around padding and single-child shapes. This adds committed coverage for the padding circuit output, root right-padding with a general checkpoint-root child, and all allowed first-block VKs in the checkpoint-root single-block path.
Fix
Testing
PATH=/home/aztec-dev/aztec-packages/noir/noir-repo/target/debug:$PATH nargo test --package rollup_lib checkpoint_padding_is_empty with_left_general_root_and_right_padding with_single_block_root --silence-warningsIssues
Created by claudebox · group:
rollup-audit-remediation