Lock governance withdrawals to voted proposal timelines#24722
Draft
AztecBot wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Governance withdrawals used the live configuration delay even after proposals had frozen longer voting and execution timing. This change records the latest vote-derived exit timestamp for each voter and clamps withdrawals so a timing-reduction proposal cannot let already-counted votes exit before the voted proposal reaches execution plus the existing buffer.
Fix
Testing
forge test --match-path test/governance/governance/scenarios/voteAndExitAfterConfigChange.t.sol -vvvforge test --match-contract 'InitiateWithdrawTest|VoteTest|NoVoteAndExitTest'git diff --checkIssues
Created by claudebox · group:
l1-audit-remediation