Reject slashing offsets before proof deadlines#24717
Draft
AztecBot wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SlashingProposeraccepted offset configurations where a target epoch's voting round could open before that epoch stopped accepting proofs. That made unsafe deployments able to execute missing-proof slashes before the proof deadline and then miss the honest post-deadline slashing window.Fix
aztecProofSubmissionEpochsintoSlashingProposerand reject offsets whereslashOffsetInRounds * roundSizeInEpochs < roundSizeInEpochs + proofSubmissionEpochs.RollupConfigurationso bad env combinations fail before deployment.Testing
forge test --match-path test/slashing/SlashingProposer.t.solforge test --match-path test/script/DeployAztecL1Contracts.t.sol(used local ignoredgenerated/HonkVerifier.solcopied fromsrc/mock/coverage/generated/HonkVerifier.sol;bootstrap.sh build_verifiercould not findnoir-protocol-circuits/target/keys/rollup_root_verifier.solin this workspace)git diff --checkIssues
Created by claudebox · group:
l1-audit-remediation