fix: reject duplicate notes from get_notes#24716
Draft
AztecBot wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_notesvalidated each hinted note independently, so a malicious witness could return the same note multiple times in one call. This change rejects duplicate note existence requests during hint confirmation, which is the narrow fix for preventing duplicated returned notes.Fix
(note_hash, contract_address)pair while confirming hinted notes and reject repeats.Testing
../../noir/noir-repo/target/debug/nargo test --package noir_aztec --exact note::note_getter::test::confirm_notes_rejects_duplicate_hinted_note --silence-warnings --test-threads 1failed before the fix withTest passed when it should have failed../../noir/noir-repo/target/debug/nargo test --package noir_aztec --exact note::note_getter::test::confirm_notes_rejects_duplicate_hinted_note --silence-warnings --test-threads 1../../noir/noir-repo/target/debug/nargo fmt --package noir_aztec../../noir/noir-repo/target/debug/nargo test --package noir_aztec --no-run --silence-warningsgit diff --checkIssues
Created by claudebox · group:
kernels-audit-remediation