fix: validate blob commitment points before batching#24715
Draft
AztecBot wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Blob commitment compression and batching accepted malformed BLS12-381 points that L1 would not accept as canonical EIP-4844 commitments. This change makes the blob crate validate the exact point representation it hashes and accumulates: canonical coordinates, canonical infinity encoding, and prime-order subgroup membership for hinted commitments.
Fix
Testing
nargo test --package blob modulus_y_infinity_point_fails --silence-warningsnargo test --package blob non_canonical_x_coordinate_fails --silence-warningsnargo test --package blob test_non_subgroup_commitment_point_fails --silence-warningsnargo test --package blob test_1_blob_batched --silence-warningsnargo test --package blob test_3_blobs_batched --silence-warningsIssues
Created by claudebox · group:
rollup-audit-remediation