fix: reject duplicate private function selectors#24712
Draft
AztecBot wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Private AuthWit action hashes bind a private function by selector, while private function membership is committed as
(selector, vkHash). This change rejects duplicate private selectors during artifact-to-class construction and private function tree construction so a class cannot commit two private functions that share the AuthWit selector identity.Fix
getContractClassFromArtifactand include colliding artifact function names in the error.Testing
git diff --checkawk 'length($0)>120 { print FILENAME ":" FNR ":" length($0) ":" $0 }' yarn-project/stdlib/src/contract/contract_class.ts yarn-project/stdlib/src/contract/contract_class.test.ts yarn-project/stdlib/src/contract/private_function.ts yarn-project/stdlib/src/contract/private_function.test.tsyarn workspace @aztec/stdlib test src/contract/contract_class.test.ts src/contract/private_function.test.ts(blocked before tests: missingnode_modulesstate)yarn install --immutable(blocked:@aztec/noir-acvm_js@portal:../noir/packages/acvm_jsmanifest not found)Issues
Created by claudebox · group:
kernels-audit-remediation