fix: omit zero-fee private tx fee writes#24710
Draft
AztecBot wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Zero-fee private txs were still emitting a FeeJuice public-data write and forcing the private tx base rollup to prove membership of an existing fee-payer balance leaf. That made valid zero-fee private txs from fee payers without an initialized FeeJuice slot unprovable. This change treats the fee-payer write as absent when the computed transaction fee is zero.
Fix
transaction_fee == 0.Testing
../../noir/noir-repo/target/debug/nargo test --package rollup_lib zero_fee_absent_fee_payer_balance_leaf_succeeds(failed before the fix withMembership check failed: public data leaf preimage does not exist in tree, passes after)../../noir/noir-repo/target/debug/nargo test --package rollup_lib tx_base::tests::private_tx_base../../noir/noir-repo/target/debug/nargo test --package rollup_lib zero_fee_omits_fee_payer_public_data_writegit diff --checkIssues
Created by claudebox · group:
kernels-audit-remediation