[DON'T MERGE] Reject non-canonical Goblin transcript coordinates#24709
Draft
AztecBot wants to merge 1 commit into
Draft
[DON'T MERGE] Reject non-canonical Goblin transcript coordinates#24709AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mega/Goblin recursive commitment decoding reconstructed BN254 Fq coordinates from raw goblin limbs without the strict canonicality check used by native and Ultra verification. This could let aliased transcript coordinates diverge from native verification behavior, so the proportionate fix is to reject non-canonical limbs at the StdlibCodec/goblin_field boundary.
Fix
goblin_field::assert_is_in_field()delegate to the strict BN254 Fqbigfieldcheck.StdlibCodecdeserializesgoblin_fieldvalues, before decoded coordinates enter transcript state.qandx + qencodings, update Mega gate-count expectations, and refresh the codec documentation.Testing
cmake --build --preset default --target stdlib_primitives_tests -j$(nproc)ctest --preset default -R 'stdlib_field_conversion' --output-on-failurecmake --build --preset default --target goblin_tests -j$(nproc)ctest --preset default -R 'GoblinRecursiveVerifierTests\.Basic$' --output-on-failure; blocked by missing/home/aztec-dev/.bb-crsBN254 CRS.Issues
Created by claudebox · group:
bb-audit-remediation