fix: pass barretenberg debug checks#24708
Draft
AztecBot wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CHECK_CIRCUIT_STACKTRACESdata across execution-trace block copies/moves and make missing trace printing a no-opRoot Cause
The debug build exposed two diagnostic-path issues.
AcirComponentsCheckTest.DetectsUnconstrainedWitnessessimulated an unconstrained witness by shrinkingbuilder.real_variable_index, leaving existing range-list entries pointing past the end of the vector; libstdc++ debug checks aborted before the components checker could report the intended error.After that was fixed,
ChonkTests.AppPairingInputsTamperingFailurehit a second debug-only path: circuit-checker diagnostics copied execution trace blocks without copying their optional stack traces, then tried to print a row's missing stack trace and threwstd::out_of_range.Verification
cmake --build barretenberg/cpp/build-debug --target acir_components_check_tests chonk_testsbarretenberg/cpp/build-debug/bin/acir_components_check_testsbarretenberg/cpp/build-debug/bin/chonk_tests --gtest_filter=ChonkTests.AppPairingInputsTamperingFailurebarretenberg/cpp/build-debug/bin/chonk_tests --gtest_filter='ChonkTests.AppPairingInputsTamperingFailure:All/KernelIOTamperingTests.CausesVerificationFailure/*'NATIVE_PRESET=debug AVM=0 AVM_TRANSPILER=0 ./barretenberg/cpp/bootstrap.sh build_nativeNATIVE_PRESET=debug AVM=0 AVM_TRANSPILER=0 ./barretenberg/cpp/bootstrap.sh test(6,987 tests in 1,292s)Created by claudebox · group:
slackbot