Reject oversized VK metadata integers#24705
Draft
AztecBot wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification-key metadata deserialization accepted field and
uint256_twords wider than the target integer type, then truncated them throughstatic_cast. This change rejects out-of-rangeuint32_tanduint64_tencodings in both native VK codec paths before casting, so malformed metadata cannot round-trip as a different value.Fix
uint32_tanduint64_tinFrCodecandU256Codec.2^32 + xand2^64 + x, plus max-value acceptance checks.from_field_elementsregression covering oversized metadata across Ultra, Mega, and UltraKeccak flavor parameters.Testing
cmake --build --preset default --target ecc_tests -j$(nproc)ctest --preset default -R 'FieldConversionTest\.(FrCodecRejectsOversizedUint32Metadata|FrCodecRejectsOversizedUint64Metadata|U256CodecRejectsOversizedUint32Metadata|U256CodecRejectsOversizedUint64Metadata|IntegerMetadataMaxValuesAccepted|FieldConversionUint32)$' --output-on-failurecmake --build --preset default --target flavor_tests -j$(nproc)ctest --preset default -R 'FromFieldElementsRejectsOversizedMetadata' --output-on-failureIssues
Created by claudebox · group:
bb-audit-remediation