Bound flat-buffer vector deserialization#24704
Draft
AztecBot wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flat-buffer vector deserialization accepted untrusted
uint32_tlengths and resized vectors before any bound check. This change adds a shared 64 MiB deserialization budget so oversized byte and generic vector lengths fail before allocation.Fix
serialize::MAX_SERIALIZED_VECTOR_BYTESand validate vector sizes by element width before every vectorresize.Testing
cmake --fresh --preset defaultcmake --build --preset default --target serialize-tests_tests -j$(nproc)ctest --preset default -R '^(Serialize\.|msgpack_tests\.)' --output-on-failureIssues
Created by claudebox · group:
bb-audit-remediation