feat(Settings): add Settings window opacity option#2709
Open
A1ca7raz wants to merge 1 commit into
Open
Conversation
- New "Settings Window opacity" slider in Theme & Colors > Modal Background - Adds settingsModalOpacity setting (default 100%, 0-100% range) - Settings modal background honors the opacity value - Make sidebar transparent so window opacity shows through - Remove redundant title bar Rectangle that caused opacity desync
Collaborator
|
We pretty much got rid of this with FloatingWindow because the compositor can simply do it better. I feel like we could tie it to the dms window rule management, for compositors that are supported by that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a "Settings Window Opacity" slider (0–100%) in Theme & Colors that makes the Settings window see through to the desktop with a surface-color tint.
For niri users: disable
shadow.draw-behind-windowof settings modal to avoid unexpected dark background.Type of change
Related issues
Screenshots / video
Checklist
I18n.tr()with translator context, reusing existing terms where possiblemake fmt, added/updated tests,make testpasses, andgo mod tidyis cleanmake lint-qmlwith no new warnings