feat!: remove Chains.Holesky - #32
Merged
Merged
Conversation
EigenLayer has sunset Holesky and Ava Protocol's testnet AVS moved to Sepolia, so the constant no longer names a chain anything in this catalog targets. Nothing here ever covered it: no protocol module and no token declares a 17000 entry, so `dist/tokens/holesky.json` was never emitted despite the sidecar's filename map and the README listing it. Verified by rebuilding — the sidecar writes the same 5 files before and after this change. BREAKING CHANGE: `Chains.Holesky` no longer exists. Callers referencing it fail to compile; there is no replacement, use `Chains.Sepolia` (11155111) for testnet. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EigenLayer has sunset Holesky and Ava Protocol's testnet AVS moved to Sepolia.
Chains.Holeskyno longer names a chain anything in this catalog targets.This is the root of a three-repo chain:
@avaprotocol/protocolsexportsChains.Holesky→ava-sdk-jsspreads the catalog into its ownChains→ the generated TypeDoc page on the docs site printsHolesky: 17000. Removing it here is the only place a fix belongs; the SDK adds nothing of its own, and the docs page is generated output.The constant was already dead
No protocol module and no token declares a
17000entry. The sidecar'sCHAIN_FILE_NAMESmapped it toholesky.jsonand the README documented that file, butbuildSidecar()derives its chain set from actualTokensentries — so the file was never emitted.Verified by rebuilding before and after; identical output either way:
So the README was documenting a file that has never existed.
Changes
src/chains.ts— dropHolesky: 17_000scripts/build-tokens-sidecar.ts— drop theCHAIN_FILE_NAMESentry and its header comment lineREADME.md— dropholesky.jsonfrom the sidecar output treeChecks
tsc --noEmitcleanvitest run— 71 tests pass across 3 filesholeskyoutside tests returns only two stale code comments inoperator/operator.go, which don't touch this catalogBreaking
Chains.Holeskyno longer exists — callers referencing it fail to compile. No replacement; useChains.Sepolia(11155111). Hence the major bump.Follow-on
Once released, bump the dep in
ava-sdk-jsand regenerate the reference docs so the docs site stops listing Holesky.