Skip to content

feat!: remove Chains.Holesky - #32

Merged
chrisli30 merged 1 commit into
mainfrom
chore/drop-holesky-chain
Aug 19, 2026
Merged

feat!: remove Chains.Holesky#32
chrisli30 merged 1 commit into
mainfrom
chore/drop-holesky-chain

Conversation

@chrisli30

Copy link
Copy Markdown
Member

EigenLayer has sunset Holesky and Ava Protocol's testnet AVS moved to Sepolia. Chains.Holesky no longer names a chain anything in this catalog targets.

This is the root of a three-repo chain: @avaprotocol/protocols exports Chains.Holeskyava-sdk-js spreads the catalog into its own Chains → the generated TypeDoc page on the docs site prints Holesky: 17000. Removing it here is the only place a fix belongs; the SDK adds nothing of its own, and the docs page is generated output.

The constant was already dead

No protocol module and no token declares a 17000 entry. The sidecar's CHAIN_FILE_NAMES mapped it to holesky.json and the README documented that file, but buildSidecar() derives its chain set from actual Tokens entries — so the file was never emitted.

Verified by rebuilding before and after; identical output either way:

[tokens-sidecar] wrote ethereum.json (104 entries)
[tokens-sidecar] wrote bnb-mainnet.json (2 entries)
[tokens-sidecar] wrote base.json (23 entries)
[tokens-sidecar] wrote base-sepolia.json (4 entries)
[tokens-sidecar] wrote sepolia.json (6 entries)
[tokens-sidecar] done: 5 files, 139 entries

So the README was documenting a file that has never existed.

Changes

  • src/chains.ts — drop Holesky: 17_000
  • scripts/build-tokens-sidecar.ts — drop the CHAIN_FILE_NAMES entry and its header comment line
  • README.md — drop holesky.json from the sidecar output tree
  • Major changeset

Checks

  • tsc --noEmit clean
  • vitest run — 71 tests pass across 3 files
  • No Go consumer references it: a sweep of EigenLayer-AVS for holesky outside tests returns only two stale code comments in operator/operator.go, which don't touch this catalog

Breaking

Chains.Holesky no longer exists — callers referencing it fail to compile. No replacement; use Chains.Sepolia (11155111). Hence the major bump.

Follow-on

Once released, bump the dep in ava-sdk-js and regenerate the reference docs so the docs site stops listing Holesky.

EigenLayer has sunset Holesky and Ava Protocol's testnet AVS moved to Sepolia,
so the constant no longer names a chain anything in this catalog targets.

Nothing here ever covered it: no protocol module and no token declares a 17000
entry, so `dist/tokens/holesky.json` was never emitted despite the sidecar's
filename map and the README listing it. Verified by rebuilding — the sidecar
writes the same 5 files before and after this change.

BREAKING CHANGE: `Chains.Holesky` no longer exists. Callers referencing it fail
to compile; there is no replacement, use `Chains.Sepolia` (11155111) for testnet.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@chrisli30
chrisli30 merged commit c74d262 into main Aug 19, 2026
7 checks passed
@chrisli30
chrisli30 deleted the chore/drop-holesky-chain branch August 19, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant