Agentic UI: Dedupe the sidebar's site start/stop toggle into a shared hook - #4611
Draft
shaunandrews wants to merge 2 commits into
Draft
Agentic UI: Dedupe the sidebar's site start/stop toggle into a shared hook#4611shaunandrews wants to merge 2 commits into
shaunandrews wants to merge 2 commits into
Conversation
… hook The status button and the row context menu each re-implemented the same busy-guarded start/stop toggle; useToggleSiteRunning is now the single source. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Aug 19, 2026
The hook had zero direct tests, and the sidebar's mock hardcoded busy: false, so the busy no-op path was untestable. Add unit tests for useToggleSiteRunning (start/stop/busy) and a sidebar test exercising the disabled, no-op state. Also fix an overclaiming docstring and collapse the row menu's two branches, now identical except their label, into one. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
AI carved this from the larger site-header exploration as a standalone dedupe.
Proposed Changes
The sidebar's status button and its row context menu each re-implemented the same busy-guarded start/stop toggle.
useToggleSiteRunningis now the single source; both consume it. The upcoming site header menu becomes a third consumer.Testing Instructions
Verification completed
npm run typecheck· site-list suite 30/30Pre-merge Checklist