Sync: preserve Pressable metadata in reconciliation fallback#4078
Open
gcsecsey wants to merge 1 commit into
Open
Sync: preserve Pressable metadata in reconciliation fallback#4078gcsecsey wants to merge 1 commit into
gcsecsey wants to merge 1 commit into
Conversation
Collaborator
📊 Performance Test ResultsComparing ca17908 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude investigated the issue, helped reduce it against WPCom with a test Pressable site, and implemented the fix.
Proposed Changes
When the Sync tab loads, Studio refreshes connected-site metadata from page 1 of
/me/sitesand fetches any connected site missing from that page individually viarest/v1.1 /sites/{id}. The single-site endpoint never returnshosting_provider_guessorenvironment_type, these are wpcom decorations that exist only on the/me/sitesendpoints, even when explicitly requested viafields. Because Pressable support is derived fromhosting_provider_guess, a successful fallback response reclassified a known Pressable site asunsupported(and could misfile staging sites), and reconciliation persisted that downgrade. Accounts with more than one page of sites, eg. the 80-site agency in STU-1977, hit this on every Sync tab load.isPressable/ staging metadata when the response lacks those fields, instead of recomputing sync support from incomplete data.hosting_provider_guess/environment_typeto the single-site endpoint) is being prepared separately, this guard protects all reconciliation paths regardless.Testing Instructions
npm test -- apps/studio/src/modules/sync/lib/tests/build-supplemental-sync-site.test.ts/me/sites):perPageinapps/studio/src/stores/sync/wpcom-sites.tsto force the fallback).syncSupport: "unsupported", isPressable: falsein~/.studio/app.json. After: it stays recognized as a connected Pressable site and remains syncable.Pre-merge Checklist