Image.getRawData method - #907
Closed
basvanmeurs wants to merge 4 commits into
Closed
Conversation
basvanmeurs
added a commit
to rdkcentral/Lightning
that referenced
this pull request
Apr 24, 2017
- texture process: prevent having to pre-process data - use image data directly (awaiting node-canvas pull request Automattic/node-canvas#907)
LinusU
reviewed
May 13, 2017
| , CanvasPattern = canvas.CanvasPattern | ||
| , ImageData = canvas.ImageData; | ||
|
|
||
| var parseCssFont = require('parse-css-font'); |
Collaborator
There was a problem hiding this comment.
The removal of this should be it's own PR, it also should remove the dependencies from the package.json...
Author
There was a problem hiding this comment.
I didn't realise that it would be part of the pull request.. that was not intentional.
Collaborator
|
@basvanmeurs if you still want this to be merged, can you clean up the branch so it contains only the relevant changes please per @LinusU's feedback? |
Collaborator
|
(I guess this is replaced by #1256) |
Author
|
Correct, it can be closed ;-) Thanks zbjornson! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background info: WPE UI Framework depends on node-canvas for creating text bitmaps, rounded edges and image parsing.
When you need to read parsed raw ARGB image data, you need to load the image, then draw it on a canvas and convert it to a buffer:
This is an unnecessary double copy of the data. This pull request contains a new method: Image.getRawData, which returns the buffer directly:
This allows for a more efficient usage of Canvas.Image.
We'd appreciate it if you'd merge this into the node-canvas module!