Skip to content

Akismet: link the settings page header logo and title to the Akismet settings page - #51449

Merged
bluefuton merged 7 commits into
trunkfrom
update/akismet-header-link-settings
Aug 25, 2026
Merged

Akismet: link the settings page header logo and title to the Akismet settings page#51449
bluefuton merged 7 commits into
trunkfrom
update/akismet-header-link-settings

Conversation

@bluefuton

@bluefuton bluefuton commented Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

  • Wrap the Akismet settings page header logo and title in a link to the Akismet settings page (admin.php?page=akismet-key-config). Akismet doesn't have a secondary nav, so clicking on the logo is important for navigation.

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  • Go to Jetpack > Akismet Anti-spam (or any Akismet admin page that uses the shared header, e.g. admin.php?page=akismet-key-config).
  • Confirm the logo and "Akismet Anti-spam" title in the header are both clickable and link to the Akismet settings page.
  • Confirm there's no underline or unexpected color change on hover/click.

@bluefuton bluefuton added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. labels Aug 20, 2026
@bluefuton bluefuton self-assigned this Aug 20, 2026
@github-actions

github-actions Bot commented Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/akismet-header-link-settings branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/akismet-header-link-settings

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions Bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Aug 21, 2026
@github-actions

github-actions Bot commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: September 7, 2026

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jp-launch-control

jp-launch-control Bot commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/plugins/jetpack/_inc/lib/admin-pages/class-akismet-admin-chrome.php 249/251 (99.20%) 99.20% -236 💚

Full summary · PHP report · JS report

@bluefuton
bluefuton requested a lite review from Copilot August 21, 2026 00:29
Copilot AI reviewed Aug 21, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Jetpack Akismet admin chrome so the header logo and “Akismet Anti-spam” title act as a single link back to the Akismet settings page (admin.php?page=akismet-key-config), aligning with the clickable header pattern used elsewhere in Jetpack admin UIs.

Changes:

  • Add a Jetpack changelog entry for the Akismet header behavior change.
  • Convert the Akismet header title container from a <div> to an <a> linking to the settings page.
  • Adjust header title styling to remove link decoration.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
projects/plugins/jetpack/changelog/update-akismet-header-link-settings Adds a Jetpack changelog entry describing the Akismet header link update.
projects/plugins/jetpack/_inc/lib/admin-pages/class-akismet-admin-chrome.php Wraps the Akismet header logo/title in a settings link and updates inline CSS for the header title.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread projects/plugins/jetpack/_inc/lib/admin-pages/class-akismet-admin-chrome.php
@bluefuton
bluefuton force-pushed the update/akismet-header-link-settings branch from c5b6a1e to e51f755 Compare August 24, 2026 05:16
@bluefuton
bluefuton force-pushed the update/akismet-header-link-settings branch from 266b460 to f374c2d Compare August 24, 2026 23:08
@bluefuton
Akismet: link the settings page header logo and title to the Akismet …
84716c1 
…settings page
@bluefuton
Akismet: show the header link focus ring for keyboard focus only
7fea512
@bluefuton
Akismet: mark the header link as the current page on the settings screen
a7d53af
@bluefuton
Akismet: escape the header aria-current attribute instead of ignoring…
6e16cd7 
… the sniff
@bluefuton
Akismet: drop aria-current from the header logo link
0168808
@bluefuton
Akismet: scope the header link focus rules to the plugin container
5ab15de 
Akismet's own `#akismet-plugin-container a:focus-visible` rule outranked the
bare class selector, so the keyboard focus ring never applied.
@bluefuton
Akismet: cover the admin chrome's registration guards and footer bran…
6e09991 
…ches

Adds unit tests for Akismet_Admin_Chrome: the init_hooks and print_styles
static guards that keep the chrome from rendering twice, both sides of the
footer byline's connectable check, and the WordPress.com branch that drops
the Products and Help links.
@bluefuton
bluefuton force-pushed the update/akismet-header-link-settings branch from f374c2d to 6e09991 Compare August 25, 2026 01:37
@bluefuton
bluefuton merged commit 5507c6d into trunk Aug 25, 2026
78 checks passed
@bluefuton
bluefuton deleted the update/akismet-header-link-settings branch August 25, 2026 02:00
@bluefuton bluefuton removed the [Status] Needs Review This PR is ready for review. label Aug 25, 2026
@github-actions github-actions Bot added this to the jetpack/16.2 milestone Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

@bluefuton bluefuton

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests

Projects

None yet

Milestone

jetpack/16.2

Development

Successfully merging this pull request may close these issues.

2 participants

@bluefuton