Remove obsolete doc-link TODO from RestrictedHooks - #898
Merged
Conversation
The `upload_mimes` group carried a TODO asking for a VIP documentation link to be added to its warning, tracked in #235. That issue has now been closed without adding a link: docs.wpvip.com documents general topics rather than individual sniffs, and no page covers safely customising `upload_mimes` or the risk of allowing insecure upload types, so there is nothing suitable to link. Left in place, the TODO points at a closed, decided-against issue and would only invite the same investigation to be repeated. The warning is clear on its own, so drop the comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
upload_mimesgroup inRestrictedHooksSniffcarried a// TODOasking for a VIP documentation link to be added to its warning, tracked in #235. That issue has since been closed without adding a link: docs.wpvip.com documents general topics rather than individual sniffs, and no page covers safely customisingupload_mimesor the risk of allowing insecure upload types, so there was nothing suitable to point at.Left in place, the comment references a closed, decided-against issue and would only prompt someone to repeat the same investigation. The warning itself ("Please ensure that the mimes being filtered do not include insecure types…") is self-explanatory, so this simply drops the comment. Comment-only change, no behaviour difference.
Follows on from the #235 triage.