Skip to content

fix(coins): remove all-time volume stat from coin UI #14542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickyrombo merged 2 commits into from
Aug 3, 2026
Merged

fix(coins): remove all-time volume stat from coin UI #14542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1041b64
fix(coins): remove all-time volume stat from coin UI
rickyrombo Aug 3, 2026
db9fd64
style: collapse responsive-policy hide arrays to satisfy prettier
rickyrombo Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/common/src/messages/coinDetailsMessages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ export const coinDetailsMessages = {
pricePerCoin: 'Price',
holdersOnAudius: 'Holders on Audius',
uniqueHolders: 'Unique Holders',
totalVolume: 'Volume (All-Time)',
marketCap: 'Market Cap',
unableToLoad: 'Unable to load insights',
graduated: 'Graduated',
Expand Down
5 changes: 0 additions & 5 deletions packages/common/src/utils/coinMetrics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ const messages = {
pricePerCoin: 'Price',
holdersOnAudius: 'Holders on Audius',
uniqueHolders: 'Unique Holders',
totalVolume: 'Volume (All-Time)',
volume24h: 'Volume (24h)',
marketCap: 'Market Cap',
graduationProgress: 'Graduation Progress'
Expand Down Expand Up @@ -78,10 +77,6 @@ export const createCoinMetrics = (coin: Coin): MetricData[] => {
value: `$${formatCount(coin.displayMarketCap ?? 0, 2)}`,
label: messages.marketCap
}),
createMetric({
value: `$${formatCount(coin.totalVolumeUSD ?? 0, 2)}`,
label: messages.totalVolume
}),
createMetric({
value: formatCount(coin.holder ?? 0),
label: messages.uniqueHolders
Expand Down
19 changes: 3 additions & 16 deletions packages/web/src/components/table/responsivePolicies.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,28 +57,15 @@ export const RESPONSIVE_TABLE_POLICIES = {
},
{
maxWidth: 815,
hide: ['holders', 'createdDate', 'marketCap', 'totalVolumeUSD']
hide: ['holders', 'createdDate', 'marketCap']
},
{
maxWidth: 671,
hide: [
'holders',
'createdDate',
'marketCap',
'totalVolumeUSD',
'artist'
]
hide: ['holders', 'createdDate', 'marketCap', 'artist']
},
{
maxWidth: 420,
hide: [
'holders',
'createdDate',
'marketCap',
'totalVolumeUSD',
'artist',
'price'
]
hide: ['holders', 'createdDate', 'marketCap', 'artist', 'price']
}
],
['tokenName', 'buy']
Expand Down
8 changes: 0 additions & 8 deletions packages/web/src/pages/fan-club-detail-page/FanClubDetailPage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,14 +95,6 @@ const assertFanClubInsightsSection = async () => {
expect(within(marketCapRow).getByText(/\$9\.0K/i)).toBeInTheDocument()
expect(within(marketCapRow).getByText(/^market cap$/i)).toBeInTheDocument()

// Volume (All-Time): $127.32
const volumeRow = screen.getByTestId('metric-row-Volume (All-Time)')
expect(volumeRow).toBeInTheDocument()
expect(within(volumeRow).getByText(/\$127\.32/)).toBeInTheDocument()
expect(
within(volumeRow).getByText(/^volume \(all-time\)$/i)
).toBeInTheDocument()

// Unique Holders: 11
const holdersRow = screen.getByTestId('metric-row-Unique Holders')
expect(holdersRow).toBeInTheDocument()
Expand Down
25 changes: 0 additions & 25 deletions packages/web/src/pages/fan-clubs-launchpad-page/components/FanClubsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,16 +184,6 @@ const renderMarketCapCell = (cellInfo: CoinCell) => {
)
}

const renderTotalVolumeUSDCell = (cellInfo: CoinCell) => {
const coin = cellInfo.row.original
return (
<Text variant='body' size='m'>
{walletMessages.dollarSign}
{formatCount(coin.totalVolumeUSD ?? 0, 2)}
</Text>
)
}

const renderHoldersCell = (cellInfo: CoinCell) => {
const coin = cellInfo.row.original
return (
Expand Down Expand Up @@ -272,19 +262,6 @@ const tableColumnMap = {
disableResizing: true,
sorter: numericSorter('price')
},
totalVolumeUSD: {
id: 'totalVolumeUSD',
Header: 'Vol',
accessor: 'totalVolumeUSD',
Cell: renderTotalVolumeUSDCell,
disableSortBy: false,
align: 'right',
width: 120,
minWidth: 120,
maxWidth: 120,
disableResizing: true,
sorter: numericSorter('totalVolumeUSD')
},
marketCap: {
id: 'marketCap',
Header: 'Market Cap',
Expand Down Expand Up @@ -340,7 +317,6 @@ const tableColumnMap = {
const sortMethodMap: Record<string, GetCoinsSortMethodEnum> = {
price: GetCoinsSortMethodEnum.Price,
marketCap: GetCoinsSortMethodEnum.MarketCap,
totalVolumeUSD: GetCoinsSortMethodEnum.Volume,
createdAt: GetCoinsSortMethodEnum.CreatedAt,
holder: GetCoinsSortMethodEnum.Holder
}
Expand Down Expand Up @@ -508,7 +484,6 @@ export const FanClubsTable = ({ viewMode }: FanClubsTableProps) => {
baseColumns.tokenName,
baseColumns.artist,
baseColumns.price,
baseColumns.totalVolumeUSD,
baseColumns.marketCap,
baseColumns.createdDate,
baseColumns.holders,
Expand Down
Loading